Issue 2275773002: Inline fast-path of Scope::LookupLocal

Issue 2275773002: Inline fast-path of Scope::LookupLocal (Closed)

Created:
4 years, 4 months ago by Toon Verwaest

Modified:
4 years, 4 months ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Inline fast-path of Scope::LookupLocal BUG=v8:5209 Committed: https://crrev.com/8547b072c83fd81fb5a9afd45edc9d92d28bcfca Cr-Commit-Position: refs/heads/master@{#38865}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	src/ast/scopes.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	src/ast/scopes.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 9 (3 generated)

adamk

lgtm Out of curiosity, did you find this sped things up on some benchmark?

4 years, 4 months ago (2016-08-23 22:07:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275773002/1

4 years, 4 months ago (2016-08-24 13:41:42 UTC) #5

Toon Verwaest

It was just high up on the profile when looking into codeload. Inlining it at ...

4 years, 4 months ago (2016-08-24 13:42:46 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-08-24 14:04:22 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8547b072c83fd81fb5a9afd45edc9d92d28bcfca
Cr-Commit-Position: refs/heads/master@{#38865}