Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2275733002: Make bisection recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix some expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -267 lines) Patch
M scripts/slave/recipes/bisection/android_bisect.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_fyi_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus6_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus9_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_arm64_aosp_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json View 1 6 chunks +6 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json View 1 4 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_no_device.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_fyi_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5X_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus6_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus7_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus9_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_one_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_cq.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_webview_arm64_aosp_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus7_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus9_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_one_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_cq.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
agable
4 years, 3 months ago (2016-08-23 20:32:05 UTC) #1
Paweł Hajdan Jr.
LGTM
4 years, 3 months ago (2016-08-24 06:42:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275733002/10001
4 years, 3 months ago (2016-08-24 16:25:00 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 16:30:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/tools/build/+/48c9aab3cb53a5c254ec...

Powered by Google App Engine
This is Rietveld 408576698