Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 227573007: Third part of porting Chrome Ash to Windows 7 (Closed)

Created:
6 years, 8 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 2 months ago
Reviewers:
ananta, oshima, sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Third part of porting Chrome Ash to Windows 7 This is the Chrome side that 1- removes windows 8 specific checks 2- disconnects the fake window_tree_host_win 3- connects the remote_window_tree_host_win With this change you can now see the ash desktop but not interact with it since input events have not been enabled. Here is the second part https://codereview.chromium.org/211863003/ First part with rationale: https://codereview.chromium.org/199843004/ BUG=356475 TEST=none

Patch Set 1 #

Patch Set 2 : updateszx #

Patch Set 3 : lf #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -73 lines) Patch
M ash/host/window_tree_host_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/host/window_tree_host_factory.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M ash/host/window_tree_host_factory_win.cc View 1 1 chunk +13 lines, -8 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/test/test_metro_viewer_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.cc View 1 chunk +12 lines, -14 lines 2 comments Download
M chrome/browser/metro_utils/metro_chrome_win.cc View 2 chunks +4 lines, -0 lines 1 comment Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 chunks +29 lines, -25 lines 0 comments Download
M win8/metro_driver/display_properties.cc View 2 chunks +4 lines, -0 lines 1 comment Download
M win8/metro_driver/metro_driver_win7.cc View 1 9 chunks +27 lines, -10 lines 1 comment Download
M win8/viewer/metro_viewer_process_host.cc View 1 2 chunks +38 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cpu_(ooo_6.6-7.5)
.
6 years, 8 months ago (2014-04-11 02:14:06 UTC) #1
cpu_(ooo_6.6-7.5)
please review: sky : chrome stuff ananta : all oshima : ash
6 years, 8 months ago (2014-04-11 02:15:58 UTC) #2
ananta
https://codereview.chromium.org/227573007/diff/40001/chrome/browser/metro_utils/metro_chrome_win.cc File chrome/browser/metro_utils/metro_chrome_win.cc (right): https://codereview.chromium.org/227573007/diff/40001/chrome/browser/metro_utils/metro_chrome_win.cc#newcode23 chrome/browser/metro_utils/metro_chrome_win.cc:23: if (base::win::GetVersion() < base::win::VERSION_WIN8) Would it make sense to ...
6 years, 8 months ago (2014-04-11 02:25:23 UTC) #3
oshima
Hi, I haven't looked into the code yet but this will conflict with my change ...
6 years, 8 months ago (2014-04-11 03:38:31 UTC) #4
sky
https://codereview.chromium.org/227573007/diff/40001/chrome/browser/browser_process_platform_part_aurawin.cc File chrome/browser/browser_process_platform_part_aurawin.cc (right): https://codereview.chromium.org/227573007/diff/40001/chrome/browser/browser_process_platform_part_aurawin.cc#newcode53 chrome/browser/browser_process_platform_part_aurawin.cc:53: CHECK(metro_viewer_process_host_->LaunchViewerAndWaitForConnection( We're not going to use the metro viewer ...
6 years, 8 months ago (2014-04-14 13:55:17 UTC) #5
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/227573007/diff/40001/chrome/browser/browser_process_platform_part_aurawin.cc File chrome/browser/browser_process_platform_part_aurawin.cc (right): https://codereview.chromium.org/227573007/diff/40001/chrome/browser/browser_process_platform_part_aurawin.cc#newcode53 chrome/browser/browser_process_platform_part_aurawin.cc:53: CHECK(metro_viewer_process_host_->LaunchViewerAndWaitForConnection( On 2014/04/14 13:55:17, sky wrote: > We're not ...
6 years, 8 months ago (2014-04-14 20:02:06 UTC) #6
cpu_(ooo_6.6-7.5)
6 years, 8 months ago (2014-04-14 20:04:16 UTC) #7
===============================
 this CL has been abandoned
===============================

Please the successor here:

https://codereview.chromium.org/235933004/

Powered by Google App Engine
This is Rietveld 408576698