src/scopes.cc - Issue 227573002: Return MaybeHandle from SetElement and DeleteElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopes.cc

Issue 227573002: Return MaybeHandle from SetElement and DeleteElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scopes.cc

diff --git a/src/scopes.cc b/src/scopes.cc

index bcb64350117130eb2bb02b32cdb23c40ed7098ae..4c4729e69ceee1d55624ddc4d278e3dec1b92495 100644

--- a/src/scopes.cc

+++ b/src/scopes.cc

@@ -1114,7 +1114,7 @@ bool Scope::ResolveVariable(CompilationInfo* info,

Isolate* isolate = info->isolate();

Factory* factory = isolate->factory();

Handle<JSArray> array = factory->NewJSArray(1);

- USE(JSObject::SetElement(array, 0, var->name(), NONE, STRICT));

+ JSObject::SetElement(array, 0, var->name(), NONE, STRICT).Assert();

Handle<Object> result =

factory->NewSyntaxError("module_type_error", array);

isolate->Throw(*result, &location);

« src/runtime.cc ('K') | « src/runtime.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »