Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: src/liveedit.cc

Issue 227573002: Return MaybeHandle from SetElement and DeleteElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 #ifdef ENABLE_DEBUGGER_SUPPORT 49 #ifdef ENABLE_DEBUGGER_SUPPORT
50 50
51 51
52 void SetElementSloppy(Handle<JSObject> object, 52 void SetElementSloppy(Handle<JSObject> object,
53 uint32_t index, 53 uint32_t index,
54 Handle<Object> value) { 54 Handle<Object> value) {
55 // Ignore return value from SetElement. It can only be a failure if there 55 // Ignore return value from SetElement. It can only be a failure if there
56 // are element setters causing exceptions and the debugger context has none 56 // are element setters causing exceptions and the debugger context has none
57 // of these. 57 // of these.
58 Handle<Object> no_failure = 58 JSObject::SetElement(object, index, value, NONE, SLOPPY).Assert();
59 JSObject::SetElement(object, index, value, NONE, SLOPPY);
60 ASSERT(!no_failure.is_null());
61 USE(no_failure);
62 } 59 }
63 60
64 61
65 // A simple implementation of dynamic programming algorithm. It solves 62 // A simple implementation of dynamic programming algorithm. It solves
66 // the problem of finding the difference of 2 arrays. It uses a table of results 63 // the problem of finding the difference of 2 arrays. It uses a table of results
67 // of subproblems. Each cell contains a number together with 2-bit flag 64 // of subproblems. Each cell contains a number together with 2-bit flag
68 // that helps building the chunk list. 65 // that helps building the chunk list.
69 class Differencer { 66 class Differencer {
70 public: 67 public:
71 explicit Differencer(Comparator::Input* input) 68 explicit Differencer(Comparator::Input* input)
(...skipping 2055 matching lines...) Expand 10 before | Expand all | Expand 10 after
2127 2124
2128 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2125 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2129 return false; 2126 return false;
2130 } 2127 }
2131 2128
2132 #endif // ENABLE_DEBUGGER_SUPPORT 2129 #endif // ENABLE_DEBUGGER_SUPPORT
2133 2130
2134 2131
2135 2132
2136 } } // namespace v8::internal 2133 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698