Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2275703003: remove point aliases (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove point aliases This removes the notion of keeping track of every different t value that resolves to the same or a similar point. Other fixes make this concept unnecessary, and removing it simplifies the code. This removes an allocation, and speeds up paths with many overlapping curves. As a bonus, four fuzzer tests that failed before now succeed. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275703003 Committed: https://skia.googlesource.com/skia/+/ef4f32ac858825dc443cfe4739ea878fb0bf550f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -75 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkOpSegment.h View 5 chunks +3 lines, -10 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 7 chunks +7 lines, -23 lines 0 comments Download
M src/pathops/SkOpSpan.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 5 chunks +7 lines, -23 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275703003/1
4 years, 4 months ago (2016-08-24 15:58:46 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:24:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ef4f32ac858825dc443cfe4739ea878fb0bf550f

Powered by Google App Engine
This is Rietveld 408576698