chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2275693003: Ntp: show footer with learn more link.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2275693003: Ntp: show footer with learn more link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9patches

Patch Set: Use the intended url. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index 3422712a923b16a34b79c03f78e13b77d449d03f..ad835a05999e9fb4218062b86ae71a21131b74d8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -210,6 +210,7 @@ public class CardViewHolder extends NewTabPageViewHolder {

/**

* Override this to provide a context menu for the card. This method will not be called if the

* card is currently peeking.

+ * @param menu The menu to add menu items to.

protected void createContextMenu(ContextMenu menu) {}

@@ -291,6 +292,7 @@ public class CardViewHolder extends NewTabPageViewHolder {

case NewTabPageItem.VIEW_TYPE_HEADER:

case NewTabPageItem.VIEW_TYPE_SPACING:

case NewTabPageItem.VIEW_TYPE_PROGRESS:

+ case NewTabPageItem.VIEW_TYPE_FOOTER:

return false;

default:

assert false;