chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2275693003: Ntp: show footer with learn more link.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2275693003: Ntp: show footer with learn more link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9patches

Patch Set: Use the intended url. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_snippets_header.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 3d136ef9825379965e1902dfc9d85bb39669a4b8..d4828cfab3bcfb20a17909a87d8da94fe1db0492 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -249,6 +249,14 @@ public class NewTabPage

}

+ @Override

+ public void onLearnMoreClicked() {

+ if (mIsDestroyed) return;

+ // TODO(mvanouwerkerk): UMA logging.

+ String url = "https://support.google.com/chrome/?p=new_tab";

+ openUrl(WindowOpenDisposition.CURRENT_TAB, url);

+ }

@TargetApi(Build.VERSION_CODES.LOLLIPOP)

private boolean switchToExistingTab(String url) {

String matchPattern = CommandLine.getInstance().getSwitchValue(