MD Downloads: use "big search" box like MD history

chrome/browser/resources/md_downloads/toolbar.html

Index: chrome/browser/resources/md_downloads/toolbar.html
diff --git a/chrome/browser/resources/md_downloads/toolbar.html b/chrome/browser/resources/md_downloads/toolbar.html
index 8dc096d4d8adba8257ef1112b6c58e1e04544224..a639ee27c58254811b3a7601c4a5335fad3587ce 100644
--- a/chrome/browser/resources/md_downloads/toolbar.html
+++ b/chrome/browser/resources/md_downloads/toolbar.html
@@ -2,46 +2,36 @@
 <link rel="import" href="chrome://resources/html/cr.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/util.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu-button/paper-menu-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
-<link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_search_field.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_toolbar/cr_toolbar.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 
 <dom-module id="downloads-toolbar">
   <template>
-    <div id="title">
-      <h1>$i18n{title}</h1>
-    </div>
-    <div id="actions">
-      <paper-button class="clear-all" on-tap="onClearAllTap_">
-        $i18n{clearAll}
-      </paper-button>
-      <paper-button on-tap="onOpenDownloadsFolderTap_">
-        $i18n{openDownloadsFolder}
-      </paper-button>
-    </div>
-    <div id="search">
-      <cr-search-field id="search-input" label="$i18n{search}"
-          clear-label="$i18n{clearSearch}"
-          on-search-changed="onSearchChanged_"></cr-search-field>
-      <paper-menu-button id="more" horizontal-align="right"
-          allow-outside-scroll>
-        <paper-icon-button icon="cr:more-vert" title="$i18n{moreActions}"
-             class="dropdown-trigger"></paper-icon-button>
-        <paper-menu class="dropdown-content">
-          <paper-item class="clear-all" on-tap="onClearAllTap_"
-              on-blur="onItemBlur_">
-            $i18n{clearAll}
-          </paper-item>
-          <paper-item on-tap="onOpenDownloadsFolderTap_" on-blur="onItemBlur_">
-            $i18n{openDownloadsFolder}
-          </paper-item>
-        </paper-menu>
-      </paper-menu-button>
-    </div>
+    <cr-toolbar id="toolbar" page-name="$i18n{title}"
+        search-prompt="$i18n{search}" clear-label="$i18n{clearSearch}"
+        showing-search="{{showingSearch_}}" spinner-active="{{spinnerActive}}"
+        show-menu="{{showMenu_}}" on-search-changed="onSearchChanged_">

[tsergeant, 2016/08/24 01:09:37]

showMenu_ and showingSearch_ don't appear to be used, can they be removed/made
constant values?

(plus, I don't think showingSearch is publically exposed from cr-toolbar)

[Dan Beam, 2016/08/24 02:48:03]

Done.
was in a local patch, didn't end up needing it.

an aside: [I still stand by the fact that] 2 custom elements named
<cr-search-field> and <cr-toolbar-search-field> share a common behavior is
confusing

+      <div class="more-actions">
+        <paper-menu-button id="more" horizontal-align="right"
+            allow-outside-scroll>
+          <paper-icon-button icon="cr:more-vert" title="$i18n{moreActions}"
+               class="dropdown-trigger"></paper-icon-button>
+          <paper-menu class="dropdown-content">
+            <paper-item class="clear-all" on-tap="onClearAllTap_"
+                on-blur="onItemBlur_">
+              $i18n{clearAll}
+            </paper-item>
+            <paper-item on-tap="onOpenDownloadsFolderTap_" on-blur="onItemBlur_">
+              $i18n{openDownloadsFolder}
+            </paper-item>
+          </paper-menu>
+        </paper-menu-button>
+      </div>
+    </cr-toolbar>
   </template>
   <link rel="import" type="css" href="chrome://downloads/shared_style.css">
   <link rel="import" type="css" href="chrome://downloads/toolbar.css">