Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: chrome/browser/resources/md_downloads/toolbar.js

Issue 2275653002: MD Downloads: use "big search" box like MD history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dl-menu-rtl
Patch Set: fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_downloads/toolbar.js
diff --git a/chrome/browser/resources/md_downloads/toolbar.js b/chrome/browser/resources/md_downloads/toolbar.js
index 4a65f5367f0035eec866b838349ac439766a1835..b830c6020475f349e221d5a0583b7898b29705ff 100644
--- a/chrome/browser/resources/md_downloads/toolbar.js
+++ b/chrome/browser/resources/md_downloads/toolbar.js
@@ -13,6 +13,11 @@ cr.define('downloads', function() {
value: false,
observer: 'downloadsShowingChanged_',
},
+
+ spinnerActive: {
+ type: Boolean,
+ notify: true,
+ },
},
listeners: {
@@ -22,16 +27,17 @@ cr.define('downloads', function() {
/** @return {boolean} Whether removal can be undone. */
canUndo: function() {
- return this.$['search-input'] != this.shadowRoot.activeElement;
+ return !this.$.toolbar.getSearchField().isSearchFocused();
},
/** @return {boolean} Whether "Clear all" should be allowed. */
canClearAll: function() {
- return !this.$['search-input'].getValue() && this.downloadsShowing;
+ return !this.$.toolbar.getSearchField().getValue() &&
+ this.downloadsShowing;
},
onFindCommand: function() {
- this.$['search-input'].showAndFocus();
+ this.$.toolbar.getSearchField().showAndFocus();
},
/** @private */
@@ -80,8 +86,9 @@ cr.define('downloads', function() {
* @private
*/
onSearchChanged_: function(event) {
- downloads.ActionService.getInstance().search(
- /** @type {string} */ (event.detail));
+ var actionService = downloads.ActionService.getInstance();
+ actionService.search(/** @type {string} */ (event.detail));
+ this.spinnerActive = actionService.isSearching();
this.updateClearAll_();
},
@@ -92,7 +99,6 @@ cr.define('downloads', function() {
/** @private */
updateClearAll_: function() {
- this.$$('#actions .clear-all').hidden = !this.canClearAll();
this.$$('paper-menu .clear-all').hidden = !this.canClearAll();
},
});
« no previous file with comments | « chrome/browser/resources/md_downloads/toolbar.html ('k') | chrome/browser/resources/md_downloads/vulcanized.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698