sdk/lib/_internal/pub/lib/src/oauth2.dart - Issue 227563010: pkg/shelf: case-insensitive headers, cleaner Request ctor, a lot more tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/oauth2.dart

Issue 227563010: pkg/shelf: case-insensitive headers, cleaner Request ctor, a lot more tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fixing dependent code, changelog Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/pub/lib/src/oauth2.dart

diff --git a/sdk/lib/_internal/pub/lib/src/oauth2.dart b/sdk/lib/_internal/pub/lib/src/oauth2.dart

index eb65e372d92295e4324f13fc26958818b534f218..b1edba05d9bb1b393d5ef947f97d0a7a82ae5c0d 100644

--- a/sdk/lib/_internal/pub/lib/src/oauth2.dart

+++ b/sdk/lib/_internal/pub/lib/src/oauth2.dart

@@ -172,12 +172,12 @@ Future<Client> _authorize() {

var server;

var completer = new Completer();

shelf_io.serve((request) {

- if (request.pathInfo != "/") {

+ if (request.url.path != "/") {

return new shelf.Response.notFound('Invalid URI.');

}

log.message('Authorization received, processing...');

- var queryString = request.queryString;

+ var queryString = request.url.query;

if (queryString == null) queryString = '';

// Closing the server here is safe, since it will wait until the response is

« no previous file with comments | « pkg/shelf/test/test_util.dart ('k') | sdk/lib/_internal/pub/test/test_pub.dart » ('j') | no next file with comments »