pkg/shelf: case-insensitive headers, cleaner Request ctor, a lot more tests

pkg/shelf/test/shelf_io_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library shelf_io_test;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
@@ skipping 66 matching lines @@
   test('Request is populated correctly', () {
     var path = '/foo/bar?qs=value#anchor';
 
     _scheduleServer((request) {
       expect(request.contentLength, 0);
       expect(request.method, 'GET');
 
       var expectedUrl = 'http://localhost:$_serverPort$path';
       expect(request.requestedUri, Uri.parse(expectedUrl));
 
-      expect(request.pathInfo, '/foo/bar');
-      expect(request.pathSegments, ['foo', 'bar']);
+      expect(request.url.path, '/foo/bar');
+      expect(request.url.pathSegments, ['foo', 'bar']);
       expect(request.protocolVersion, '1.1');
-      expect(request.queryString, 'qs=value');
+      expect(request.url.query, 'qs=value');
       expect(request.scriptName, '');
 
       return syncHandler(request);
     });
 
     return schedule(() => http.get('http://localhost:$_serverPort$path'))
         .then((response) {
       expect(response.statusCode, HttpStatus.OK);
       expect(response.body, 'Hello from /foo/bar');
     });
@@ skipping 21 matching lines @@
 
     return _scheduleGet().then((response) {
       expect(response.statusCode, 299);
       expect(response.body, 'Hello from /');
     });
   });
 
   test('custom request headers are received by the handler', () {
     _scheduleServer((request) {
       expect(request.headers, containsPair('custom-header', 'client value'));
+
+      // dart:io HttpServer splits multi-value headers into an array
+      // validate that they are combined correctly
+      expect(request.headers, containsPair('multi-header', 'foo,bar,baz'));
       return syncHandler(request);
     });
 
     var headers = {
-      'custom-header': 'client value'
+      'custom-header': 'client value',
+      'multi-header': 'foo,bar,baz'
     };
 
     return _scheduleGet(headers: headers).then((response) {
       expect(response.statusCode, HttpStatus.OK);
       expect(response.body, 'Hello from /');
     });
   });
 
   test('post with empty content', () {
     _scheduleServer((request) {
@@ skipping 61 matching lines @@
 
     var request = new http.Request('POST',
         Uri.parse('http://localhost:$_serverPort/'));
 
     if (headers != null) request.headers.addAll(headers);
     if (body != null) request.body = body;
 
     return request.send();
   });
 }