pkg/shelf: case-insensitive headers, cleaner Request ctor, a lot more tests

pkg/shelf/test/shelf_io_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library shelf_io_test;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
@@ skipping 111 matching lines @@
 
     return _scheduleGet().then((response) {
       expect(response.statusCode, 299);
       expect(response.body, 'Hello from /');
     });
   });
 
   test('custom request headers are received by the handler', () {
     _scheduleServer((request) {
       expect(request.headers, containsPair('custom-header', 'client value'));
+
+      // dart:io HttpServer splits multi-value headers into an array
+      // validate that they are combined correctly
+      expect(request.headers, containsPair('multi-header', 'foo,bar,baz'));
       return syncHandler(request);
     });
 
     var headers = {
-      'custom-header': 'client value'
+      'custom-header': 'client value',
+      'multi-header': 'foo,bar,baz'

[nweiz, 2014/04/08 20:23:09]

Does dart:io really split comma-separated header values? I thought it considered
multiple headers with the same name as separate.

[kevmoo, 2014/04/08 21:41:13]

HttpHeaders stores values in a List. shelf_io does a join to turn them back into
a string. This is just checked to make sure the round-trip is valid.

     };
 
     return _scheduleGet(headers: headers).then((response) {
       expect(response.statusCode, HttpStatus.OK);
       expect(response.body, 'Hello from /');
     });
   });
 
   test('post with empty content', () {
     _scheduleServer((request) {
@@ skipping 61 matching lines @@
 
     var request = new http.Request('POST',
         Uri.parse('http://localhost:$_serverPort/'));
 
     if (headers != null) request.headers.addAll(headers);
     if (body != null) request.body = body;
 
     return request.send();
   });
 }