pkg/shelf: case-insensitive headers, cleaner Request ctor, a lot more tests

pkg/shelf/lib/shelf_io.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// A Shelf adapter for handling [HttpRequest] objects from `dart:io`.
 ///
 /// One can provide an instance of [HttpServer] as the `requests` parameter in
 /// [serveRequests].
 library shelf.io;
 
@@ skipping 47 matching lines @@
     if (response == null) {
       response = _logError('null response from handler');
     }
 
     return _writeResponse(response, request.response);
   });
 }
 
 /// Creates a new [Request] from the provided [HttpRequest].
 Request _fromHttpRequest(HttpRequest request) {
-  //TODO(kevmoo): make headers case-insensitive
   var headers = {};
   request.headers.forEach((k, v) {
     // Multiple header values are joined with commas.
     // See http://tools.ietf.org/html/draft-ietf-httpbis-p1-messaging-21#page-22
     headers[k] = v.join(',');
   });
 
-  return new Request(request.uri.path, request.uri.query, request.method,
-      '', request.protocolVersion, request.requestedUri,
-      headers, body: request);
+  return new Request(request.protocolVersion, request.method, headers,
+      request.requestedUri, body: request);
 }
 
 Future _writeResponse(Response response, HttpResponse httpResponse) {
   httpResponse.statusCode = response.statusCode;
 
   response.headers.forEach((header, value) {
     if (value == null) return;
     httpResponse.headers.set(header, value);
   });
 
   if (response.headers[HttpHeaders.SERVER] == null) {
     var value = httpResponse.headers.value(HttpHeaders.SERVER);
     httpResponse.headers.set(HttpHeaders.SERVER, '$value with Shelf');
   }
   return httpResponse.addStream(response.read())
       .then((_) => httpResponse.close());
 }
 
 // TODO(kevmoo) A developer mode is needed to include error info in response
 // TODO(kevmoo) Make error output plugable. stderr, logging, etc
 Response _logError(String message) {
   stderr.writeln('ERROR - ${new DateTime.now()}');
   stderr.writeln(message);
   return new Response.internalServerError();
 }