Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 227563004: Re-land 261836 "Restore --child-clean-exit behavior for ASan/LSan..." (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Re-land 261836 "Restore --child-clean-exit behavior for ASan/LSan..." This change uncovered a crash in unrelated code on ChromeOS, and was reverted in r262012. The crash has been filed under http://crbug.com/360622. As a temporary measure I'm re-landing the change under "#if !defined(OS_CHROMEOS)". BUG=360622, 324216, 307043 TBR=jam@chromium.org TEST=compile NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M content/browser/child_process_launcher.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +53 lines, -0 lines 0 comments Download
M tools/lsan/suppressions.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
earthdok
ptal
6 years, 8 months ago (2014-04-07 18:30:24 UTC) #1
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 8 months ago (2014-04-07 20:02:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/227563004/1
6 years, 8 months ago (2014-04-07 20:03:44 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 20:03:44 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-07 20:03:45 UTC) #5
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 8 months ago (2014-04-07 20:08:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/227563004/1
6 years, 8 months ago (2014-04-07 20:09:41 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 20:11:11 UTC) #8
Message was sent while issue was closed.
Change committed as 262184

Powered by Google App Engine
This is Rietveld 408576698