Bookmark Suggestions: Make 'creation date fallback' time configurable

components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index d128b82ae212d95ddcc56359819c4458f8a62d02..1d39e5eebc3c8736565b45e15833a90ee24ed7ac 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -39,6 +39,8 @@ const int kUseCreationDateFallbackForDays = 42;
 const char* kMaxBookmarksParamName = "bookmarks_max_count";
 const char* kMinBookmarksParamName = "bookmarks_min_count";
 const char* kMaxBookmarkAgeInDaysParamName = "bookmarks_max_age_in_days";
+const char* kUseCreationDateFallbackForDaysParamName =
+    "bookmarks_creation_date_fallback_days";
 
 base::Time GetThresholdTime() {
   std::string age_in_days_string = variations::GetVariationParamValueByFeature(
@@ -52,6 +54,19 @@ base::Time GetThresholdTime() {
   return base::Time::Now() - base::TimeDelta::FromDays(age_in_days);
 }
 
+int UseCreationDateFallbackForDays() {
+  std::string days_string = variations::GetVariationParamValueByFeature(
+      ntp_snippets::kBookmarkSuggestionsFeature,
+      kUseCreationDateFallbackForDaysParamName);
+  int days = 0;
+  if (!base::StringToInt(days_string, &days)) {
+    if (!days_string.empty())
+      LOG(WARNING) << "Failed to parse bookmark fallback days " << days_string;
+    days = kUseCreationDateFallbackForDays;
+  }
+  return days;
+}
+
 int GetMaxCount() {
   std::string max_count_string = variations::GetVariationParamValueByFeature(
       ntp_snippets::kBookmarkSuggestionsFeature, kMaxBookmarksParamName);
@@ -105,7 +120,7 @@ BookmarkSuggestionsProvider::BookmarkSuggestionsProvider(
   }
   base::TimeDelta time_since_first_m54_start = now - first_m54_start;
   creation_date_fallback_ =
-      time_since_first_m54_start.InDays() < kUseCreationDateFallbackForDays;
+      time_since_first_m54_start.InDays() < UseCreationDateFallbackForDays();

[sfiera, 2016/08/23 15:31:14]

Seems like setting "0" (or negative) would have the effect of disabling
fallback. Intentional? Do you want to document that?

[Marc Treib, 2016/08/23 15:35:19]

That's exactly the behavior you'd expect, no? Use the fallback for 0 days?

[sfiera, 2016/08/23 15:42:04]

I might expect that "0" would mean "use the compiled default".

[Marc Treib, 2016/08/23 16:09:38]

I'd expect a comment if it meant that!
Anyway, comment added.

   bookmark_model_->AddObserver(this);
   FetchBookmarks();
 }