Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2275603004: Add empty kernel-ssa test (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Also add a status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M tests/compiler/dart2js/dart2js.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/empty_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/helper.dart View 1 chunk +37 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:26 UTC) #9
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:26 UTC) #10
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:26 UTC) #11
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:27 UTC) #12
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:27 UTC) #13
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:27 UTC) #14
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:27 UTC) #15
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:27 UTC) #16
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:27 UTC) #17
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 20:05:28 UTC) #18
Harry Terkelsen
lgtm
4 years, 4 months ago (2016-08-24 20:34:32 UTC) #19
Siggi Cherem (dart-lang)
I went ahead and also added a status file to mark the test as failing ...
4 years, 4 months ago (2016-08-24 21:27:25 UTC) #20
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-24 21:27:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8445c85aa68aa93ed1a3350867edfd70969880e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698