core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp - Issue 2275593002: IndirectObjectHolder API updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

Issue 2275593002: IndirectObjectHolder API updates (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Missed one Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

index 12a36d921a895b74a4d4962ac8b2c1882d034746..efad3c38f65de0e11fda489460b3ccb1f4cf8490 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

@@ -116,7 +116,7 @@ TEST(cpdf_array, Clone) {

CPDF_Number* obj = new CPDF_Number(elems[i][j]);

// Starts object number from 1.

int obj_num = i * kNumOfRowElems + j + 1;

- obj_holder->InsertIndirectObject(obj_num, obj);

+ obj_holder->ReplaceIndirectObjectIfHigherGeneration(obj_num, obj);

arr_elem->InsertAt(j, new CPDF_Reference(obj_holder.get(), obj_num),

obj_holder.get());

}