Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Issue 2275583002: Revert of [heap] Tracer: Handle incremental marking scopes (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Tracer: Handle incremental marking scopes (patchset #4 id:100001 of https://codereview.chromium.org/2264033002/ ) Reason for revert: Unittest fails on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/4188/steps/Check/logs/GCTracerTest.Incremen.. Original issue's description: > [heap] Tracer: Handle incremental marking scopes > > Before this patch all tracing scopes in incremental marking would be reset > during a gc tracer start/stop cycle. This patch handles scopes the same way it > does other incremental marking metrics. > > Also: > - Align finalization metric with regular marking metric. > - Smaller cleanups > > BUG=chromium:639818 > R=jochen@chromium.org > > Committed: https://crrev.com/300a8f97472b88ff2f94eb977c36b4bf1bedabf1 > Cr-Commit-Position: refs/heads/master@{#38822} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639818 Committed: https://crrev.com/0f4f30a1d2243d73673dab3319b17d0ba421f187 Cr-Commit-Position: refs/heads/master@{#38827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -358 lines) Patch
M src/heap/gc-tracer.h View 8 chunks +53 lines, -108 lines 0 comments Download
M src/heap/gc-tracer.cc View 11 chunks +56 lines, -98 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +97 lines, -0 lines 0 comments Download
M test/unittests/heap/gc-tracer-unittest.cc View 2 chunks +0 lines, -141 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Lippautz
Created Revert of [heap] Tracer: Handle incremental marking scopes
4 years, 4 months ago (2016-08-23 14:14:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275583002/1
4 years, 4 months ago (2016-08-23 14:15:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 14:15:14 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 14:15:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f4f30a1d2243d73673dab3319b17d0ba421f187
Cr-Commit-Position: refs/heads/master@{#38827}

Powered by Google App Engine
This is Rietveld 408576698