Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2275573002: Remove rest_parameter_ cache on DeclarationScope (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove rest_parameter_ cache on DeclarationScope We anyway have its index in params_, so just always access through params_. BUG=v8:5209 Committed: https://crrev.com/9f4c8b745a85eed40d24e856fc1995efe6f441b0 Cr-Commit-Position: refs/heads/master@{#38836}

Patch Set 1 #

Patch Set 2 : Could be we shouldn't allocate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M src/ast/scopes.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 1 4 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-23 14:07:23 UTC) #2
neis
On 2016/08/23 14:07:23, Toon Verwaest wrote: > ptal lgtm. may want to replace the index ...
4 years, 4 months ago (2016-08-23 14:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275573002/1
4 years, 4 months ago (2016-08-23 14:21:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11436) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-23 14:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275573002/20001
4 years, 4 months ago (2016-08-23 14:57:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 15:28:11 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 15:28:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f4c8b745a85eed40d24e856fc1995efe6f441b0
Cr-Commit-Position: refs/heads/master@{#38836}

Powered by Google App Engine
This is Rietveld 408576698