base/win/event_trace_controller_unittest.cc - Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/event_trace_controller_unittest.cc

Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/win/event_trace_controller_unittest.cc

diff --git a/base/win/event_trace_controller_unittest.cc b/base/win/event_trace_controller_unittest.cc

index 3eeeb88a79da32e100e2250291e30be2f767f4f3..f19ee31dd132441924950618a3eb0d64eb6116a6 100644

--- a/base/win/event_trace_controller_unittest.cc

+++ b/base/win/event_trace_controller_unittest.cc

@@ -161,7 +161,7 @@ TEST_F(EtwTraceControllerTest, StartFileSession) {

ScopedTempDir temp_dir;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

FilePath temp;

- ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir.path(), &temp));

+ ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir.GetPath(), &temp));

EtwTraceController controller;

HRESULT hr = controller.StartFileSession(session_name_.c_str(),

« no previous file with comments | « base/win/event_trace_consumer_unittest.cc ('k') | base/win/shortcut_unittest.cc » ('j') | no next file with comments »