Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Unified Diff: base/files/file_locking_unittest.cc

Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/dir_reader_posix_unittest.cc ('k') | base/files/file_path_watcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_locking_unittest.cc
diff --git a/base/files/file_locking_unittest.cc b/base/files/file_locking_unittest.cc
index d9a1755563e6d0cabe9fc1fe008c03ea087c8106..beb93998c4c672ea5d3fb5ad9495e33a6e693eda 100644
--- a/base/files/file_locking_unittest.cc
+++ b/base/files/file_locking_unittest.cc
@@ -129,17 +129,17 @@ class FileLockingTest : public testing::Test {
// Setup the temp dir and the lock file.
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
lock_file_.Initialize(
- temp_dir_.path().AppendASCII(kLockFile),
+ temp_dir_.GetPath().AppendASCII(kLockFile),
File::FLAG_CREATE | File::FLAG_READ | File::FLAG_WRITE);
ASSERT_TRUE(lock_file_.IsValid());
}
bool SignalEvent(const char* signal_file) {
- return ::SignalEvent(temp_dir_.path(), signal_file);
+ return ::SignalEvent(temp_dir_.GetPath(), signal_file);
}
bool WaitForEventOrTimeout(const char* signal_file) {
- return ::WaitForEventWithTimeout(temp_dir_.path(), signal_file,
+ return ::WaitForEventWithTimeout(temp_dir_.GetPath(), signal_file,
TestTimeouts::action_timeout());
}
@@ -147,7 +147,7 @@ class FileLockingTest : public testing::Test {
// it to lock the file.
void StartChildAndSignalLock(const char* unlock_action) {
// Create a temporary dir and spin up a ChildLockExit subprocess against it.
- const FilePath temp_path = temp_dir_.path();
+ const FilePath temp_path = temp_dir_.GetPath();
base::CommandLine child_command_line(
base::GetMultiProcessTestChildBaseCommandLine());
child_command_line.AppendSwitchPath(kTempDirFlag, temp_path);
« no previous file with comments | « base/files/dir_reader_posix_unittest.cc ('k') | base/files/file_path_watcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698