base/test/launcher/unit_test_launcher.cc - Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/launcher/unit_test_launcher.cc

Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a hint to the DCHECK Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/test/launcher/unit_test_launcher.cc

diff --git a/base/test/launcher/unit_test_launcher.cc b/base/test/launcher/unit_test_launcher.cc

index aeb96aca97c741b72c9052b93b7ff50cdb047a2f..ad956dbbe21934f59d4421e89156d4aa524d7260 100644

--- a/base/test/launcher/unit_test_launcher.cc

+++ b/base/test/launcher/unit_test_launcher.cc

@@ -121,7 +121,7 @@ class DefaultUnitTestPlatformDelegate : public UnitTestPlatformDelegate {

CHECK(temp_dir_.IsValid() || temp_dir_.CreateUniqueTempDir());

FilePath temp_file;

- CHECK(CreateTemporaryFileInDir(temp_dir_.path(), &temp_file));

+ CHECK(CreateTemporaryFileInDir(temp_dir_.GetPath(), &temp_file));

std::string long_flags(

std::string("--") + kGTestFilterFlag + "=" +

JoinString(test_names, ":"));

« base/files/file_util_proxy_unittest.cc ('K') | « base/test/launcher/test_launcher_ios.cc ('k') | base/test/scoped_path_override.cc » ('j') | no next file with comments »