base/metrics/persistent_histogram_allocator_unittest.cc - Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_histogram_allocator_unittest.cc

Issue 2275553005: //base: Make ScopedTempDir::path() a GetPath() with a DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a hint to the DCHECK Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/persistent_histogram_allocator_unittest.cc

diff --git a/base/metrics/persistent_histogram_allocator_unittest.cc b/base/metrics/persistent_histogram_allocator_unittest.cc

index b6806622502d1fdc9aebac6183621e9da0efd8a0..6f9ed96481cace40703b884a5e06890e33385944 100644

--- a/base/metrics/persistent_histogram_allocator_unittest.cc

+++ b/base/metrics/persistent_histogram_allocator_unittest.cc

@@ -131,7 +131,7 @@ TEST_F(PersistentHistogramAllocatorTest, CreateWithFileTest) {

const char temp_name[] = "CreateWithFileTest";

ScopedTempDir temp_dir;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

- FilePath temp_file = temp_dir.path().AppendASCII(temp_name);

+ FilePath temp_file = temp_dir.GetPath().AppendASCII(temp_name);

const size_t temp_size = 64 << 10; // 64 KiB

// Test creation of a new file.

« base/files/file_util_proxy_unittest.cc ('K') | « base/mac/mac_util_unittest.mm ('k') | base/metrics/persistent_memory_allocator_unittest.cc » ('j') | no next file with comments »