//base: Make ScopedTempDir::path() a GetPath() with a DCHECK

base/files/file_util_proxy_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util_proxy.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 24 matching lines @@
                       const File::Info& file_info) {
     error_ = error;
     file_info_ = file_info;
     MessageLoop::current()->QuitWhenIdle();
   }
 
  protected:
   TaskRunner* file_task_runner() const {
     return file_thread_.task_runner().get();
   }
-  const FilePath& test_dir_path() const { return dir_.path(); }
-  const FilePath test_path() const { return dir_.path().AppendASCII("test"); }
+  const FilePath TestPath() const { return dir_.GetPath().AppendASCII("test"); }
 
   MessageLoopForIO message_loop_;
   Thread file_thread_;
 
   ScopedTempDir dir_;
   File::Error error_;
   FilePath path_;
   File::Info file_info_;
   std::vector<char> buffer_;
   WeakPtrFactory<FileUtilProxyTest> weak_factory_;
 };
 
 
 TEST_F(FileUtilProxyTest, GetFileInfo_File) {
   // Setup.
-  ASSERT_EQ(4, WriteFile(test_path(), "test", 4));
+  ASSERT_EQ(4, WriteFile(TestPath(), "test", 4));
   File::Info expected_info;
-  GetFileInfo(test_path(), &expected_info);
+  GetFileInfo(TestPath(), &expected_info);
 
   // Run.
   FileUtilProxy::GetFileInfo(
-      file_task_runner(),
-      test_path(),
+      file_task_runner(), TestPath(),
       Bind(&FileUtilProxyTest::DidGetFileInfo, weak_factory_.GetWeakPtr()));
   RunLoop().Run();
 
   // Verify.
   EXPECT_EQ(File::FILE_OK, error_);
   EXPECT_EQ(expected_info.size, file_info_.size);
   EXPECT_EQ(expected_info.is_directory, file_info_.is_directory);
   EXPECT_EQ(expected_info.is_symbolic_link, file_info_.is_symbolic_link);
   EXPECT_EQ(expected_info.last_modified, file_info_.last_modified);
   EXPECT_EQ(expected_info.last_accessed, file_info_.last_accessed);
   EXPECT_EQ(expected_info.creation_time, file_info_.creation_time);
 }
 
 TEST_F(FileUtilProxyTest, GetFileInfo_Directory) {
   // Setup.
-  ASSERT_TRUE(base::CreateDirectory(test_path()));
+  ASSERT_TRUE(base::CreateDirectory(TestPath()));
   File::Info expected_info;
-  GetFileInfo(test_path(), &expected_info);
+  GetFileInfo(TestPath(), &expected_info);
 
   // Run.
   FileUtilProxy::GetFileInfo(
-      file_task_runner(),
-      test_path(),
+      file_task_runner(), TestPath(),
       Bind(&FileUtilProxyTest::DidGetFileInfo, weak_factory_.GetWeakPtr()));
   RunLoop().Run();
 
   // Verify.
   EXPECT_EQ(File::FILE_OK, error_);
   EXPECT_EQ(expected_info.size, file_info_.size);
   EXPECT_EQ(expected_info.is_directory, file_info_.is_directory);
   EXPECT_EQ(expected_info.is_symbolic_link, file_info_.is_symbolic_link);
   EXPECT_EQ(expected_info.last_modified, file_info_.last_modified);
   EXPECT_EQ(expected_info.last_accessed, file_info_.last_accessed);
   EXPECT_EQ(expected_info.creation_time, file_info_.creation_time);
 }
 
 TEST_F(FileUtilProxyTest, Touch) {
-  ASSERT_EQ(4, WriteFile(test_path(), "test", 4));
+  ASSERT_EQ(4, WriteFile(TestPath(), "test", 4));
   Time last_accessed_time = Time::Now() - TimeDelta::FromDays(12345);
   Time last_modified_time = Time::Now() - TimeDelta::FromHours(98765);
 
   FileUtilProxy::Touch(
-      file_task_runner(),
-      test_path(),
-      last_accessed_time,
-      last_modified_time,
+      file_task_runner(), TestPath(), last_accessed_time, last_modified_time,
       Bind(&FileUtilProxyTest::DidFinish, weak_factory_.GetWeakPtr()));
   RunLoop().Run();
   EXPECT_EQ(File::FILE_OK, error_);
 
   File::Info info;
-  GetFileInfo(test_path(), &info);
+  GetFileInfo(TestPath(), &info);
 
   // The returned values may only have the seconds precision, so we cast
   // the double values to int here.
   EXPECT_EQ(static_cast<int>(last_modified_time.ToDoubleT()),
             static_cast<int>(info.last_modified.ToDoubleT()));
   EXPECT_EQ(static_cast<int>(last_accessed_time.ToDoubleT()),
             static_cast<int>(info.last_accessed.ToDoubleT()));
 }
 
 }  // namespace base