Issue 227553003: Fixed flooring division by -1 on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227553003: Fixed flooring division by -1 on ARM. (Closed)

Created:
6 years, 8 months ago by Sven Panne

Modified:
6 years, 8 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixed flooring division by -1 on ARM. We should avoid ASR #0 on ARM. Simplified and improved code a bit while we're there on all platforms. Human brains are very bad at understanding nested structures... BUG=v8:3259 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20544

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -44 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+13 lines, -11 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 chunk	+17 lines, -11 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+15 lines, -11 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+17 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

As discussed offline, no test case attached, it would break quite soon, anyway.

6 years, 8 months ago (2014-04-07 11:50:21 UTC) #1

Sven Panne

6 years, 8 months ago (2014-04-07 12:08:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20544 (presubmit successful).