Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2275523003: Update iOS neutral omnibox icon from page icon to info icon. (Closed)

Created:
4 years, 4 months ago by lgarron
Modified:
4 years, 3 months ago
CC:
chromium-reviews, justincohen, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update iOS neutral omnibox icon from page icon to info icon. BUG=634938 Committed: https://crrev.com/a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9 Cr-Commit-Position: refs/heads/master@{#414905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/resources/omnibox_scaled_resources.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
lgarron
jochen@, could you review? See https://crbug.com/634938#c7 for screenshot.
4 years, 4 months ago (2016-08-24 07:00:43 UTC) #2
felt
On 2016/08/24 07:00:43, lgarron wrote: > jochen@, could you review? > > See https://crbug.com/634938#c7 for ...
4 years, 4 months ago (2016-08-24 14:11:36 UTC) #3
lgarron
On 2016/08/24 at 14:11:36, felt wrote: > On 2016/08/24 07:00:43, lgarron wrote: > > jochen@, ...
4 years, 4 months ago (2016-08-24 20:38:20 UTC) #4
jochen (gone - plz use gerrit)
after this change, the location_bar_http.png file appears to be unused. can we delete it?
4 years, 4 months ago (2016-08-24 20:50:46 UTC) #5
lgarron
On 2016/08/24 at 20:50:46, jochen wrote: > after this change, the location_bar_http.png file appears to ...
4 years, 4 months ago (2016-08-25 01:11:21 UTC) #6
lgarron
On 2016/08/25 at 01:11:21, lgarron wrote: > On 2016/08/24 at 20:50:46, jochen wrote: > > ...
4 years, 4 months ago (2016-08-25 01:57:05 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-25 21:01:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275523003/1
4 years, 3 months ago (2016-08-27 02:11:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 10:51:44 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 10:54:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9
Cr-Commit-Position: refs/heads/master@{#414905}

Powered by Google App Engine
This is Rietveld 408576698