chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java - Issue 2275513003: Move usage and crash reporting to opt-out by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

Issue 2275513003: Move usage and crash reporting to opt-out by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unittests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

index 2ebed96d34158787b336c2510d21812985576498..236a1da1245997162b660c9d5b05ba5c4255fdf0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

@@ -156,8 +156,7 @@ public class UmaSessionStats implements NetworkChangeNotifier.ConnectionTypeObse

* Updates the state of the MetricsService to account for the user's preferences.

public void updateMetricsServiceState() {

- boolean mayRecordStats = !PrivacyPreferencesManager.getInstance()

- .isNeverUploadCrashDump();

+ boolean mayRecordStats = PrivacyPreferencesManager.getInstance().isUploadUserPermitted();

boolean mayUploadStats = mReportingPermissionManager.isUmaUploadPermitted();

// Re-start the MetricsService with the given parameters.