Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

Issue 2275513003: Move usage and crash reporting to opt-out by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unittests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
index d21a02a6553a98b47f7835c725a31586d9081a56..c2d856c712b33f1fbcf003d496f8d7c1f77a75c8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.crash;
-import android.content.Context;
import android.content.SharedPreferences;
import android.support.annotation.IntDef;
@@ -69,7 +68,7 @@ public class MinidumpUploadCallable implements Callable<Integer> {
private final HttpURLConnectionFactory mHttpURLConnectionFactory;
private final CrashReportingPermissionManager mPermManager;
- public MinidumpUploadCallable(File fileToUpload, File logfile, Context context) {
+ public MinidumpUploadCallable(File fileToUpload, File logfile) {
Ilya Sherman 2016/08/25 19:56:51 Optional nit: This change looks fine, but doesn't
gayane -on leave until 09-2017 2016/08/25 20:50:15 reverted unrelated cleanup
this(fileToUpload, logfile, new HttpURLConnectionFactoryImpl(),
PrivacyPreferencesManager.getInstance());
removeOutdatedPrefs(ContextUtils.getAppSharedPreferences());

Powered by Google App Engine
This is Rietveld 408576698