Remove EventSender from HTMLLinkElement

Remove EventSender from HTMLLinkElement

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697
Committed: https://crrev.com/aaf5ece46ff3b24c2f5ff0054600900f60c70ce4
Cr-Commit-Position: refs/heads/master@{#418835}

[hiroshige, 2016-08-31 05:35:13]

Patchset #3 (id:40001) has been deleted

[hiroshige, 2016-08-31 05:35:21]

Patchset #3 (id:60001) has been deleted

[hiroshige, 2016-08-31 06:30:30]

Description was changed from

==========
Remove EventSender from HTMLLinkElement

BUG=
==========

to

==========
Remove EventSender from HTMLLinkElement

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697
==========

[hiroshige, 2016-08-31 06:33:22]

Patchset #4 (id:100001) has been deleted

[hiroshige, 2016-09-01 08:26:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 08:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 09:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 09:45:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-09-01 11:57:30]

hiroshige@chromium.org changed reviewers:
+ haraken@chromium.org, nhiroki@chromium.org

[hiroshige, 2016-09-01 11:57:31]

PTAL.

I replaced EventSender with postTask() to the loading task runner. Is it a right
task runner?

A test http/tests/preload/multiple-meta-csp.html is failing, but I'm thinking I
have to modify the test or blink::Internals (to be done soon).

[haraken, 2016-09-01 17:48:37]

https://codereview.chromium.org/2275493002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/2275493002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLLinkElement.cpp:316:
TaskRunnerHelper::getLoadingTaskRunner(&document())->postTask(BLINK_FROM_HERE,
WTF::bind(&HTMLLinkElement::dispatchPendingEvent, wrapPersistent(this),
passed(IncrementLoadEventDelayCount::create(document()))));

TaskRunnerHelper::getXXXTaskRunner has been deprecated (sorry I should have
removed them). Use TaskRunnerHelper::get().

Per the spec
(https://html.spec.whatwg.org/multipage/semantics.html#the-link-element), we
should use TaskType::DOMManipulation.

[hiroshige, 2016-09-02 10:11:26]

(The test failure is tracked by crbug.com/643621.)

https://codereview.chromium.org/2275493002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/HTMLLinkElement.cpp (right):

https://codereview.chromium.org/2275493002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/HTMLLinkElement.cpp:316:
TaskRunnerHelper::getLoadingTaskRunner(&document())->postTask(BLINK_FROM_HERE,
WTF::bind(&HTMLLinkElement::dispatchPendingEvent, wrapPersistent(this),
passed(IncrementLoadEventDelayCount::create(document()))));
On 2016/09/01 17:48:37, haraken wrote:
> 
> TaskRunnerHelper::getXXXTaskRunner has been deprecated (sorry I should have
> removed them). Use TaskRunnerHelper::get().
> 
> Per the spec
> (https://html.spec.whatwg.org/multipage/semantics.html#the-link-element), we
> should use TaskType::DOMManipulation.

Thanks! Modified.

[haraken, 2016-09-02 10:23:07]

haraken@chromium.org changed reviewers:
+ alexclarke@chromium.org, skyostil@chromium.org

[haraken, 2016-09-02 10:23:08]

LGTM

[Yoav Weiss, 2016-09-02 10:28:03]

On 2016/09/02 10:11:26, hiroshige wrote:
> (The test failure is tracked by crbug.com/643621.)

In this particular case, I don't think isPreloaded is actually testing what it
should be. (even if the preloadScanner wouldn't have run at all, I think
isPreloaded() would have returned true before the document's onload)

[Yoav Weiss, 2016-09-02 10:31:48]

On 2016/09/02 10:28:03, Yoav Weiss wrote:
> On 2016/09/02 10:11:26, hiroshige wrote:
> > (The test failure is tracked by crbug.com/643621.)
> 
> In this particular case, I don't think isPreloaded is actually testing what it
> should be. (even if the preloadScanner wouldn't have run at all, I think
> isPreloaded() would have returned true before the document's onload)

Looking at the code again, I might be wrong about that...

[nhiroki, 2016-09-05 02:00:40]

lgtm

[hiroshige, 2016-09-15 10:10:13]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-09-15 10:10:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2275493002/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-15 10:10:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-09-15 10:14:30]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-09-15 10:15:05]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:15:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:18:41]

Description was changed from

==========
Remove EventSender from HTMLLinkElement

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697
==========

to

==========
Remove EventSender from HTMLLinkElement

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697
==========

[commit-bot: I haz the power, 2016-09-15 11:18:42]

Committed patchset #8 (id:200001)

[commit-bot: I haz the power, 2016-09-15 11:20:54]

Description was changed from

==========
Remove EventSender from HTMLLinkElement

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697
==========

to

==========
Remove EventSender from HTMLLinkElement

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697

Committed: https://crrev.com/aaf5ece46ff3b24c2f5ff0054600900f60c70ce4
Cr-Commit-Position: refs/heads/master@{#418835}
==========

[commit-bot: I haz the power, 2016-09-15 11:20:55]

Patchset 8 (id:??) landed as
https://crrev.com/aaf5ece46ff3b24c2f5ff0054600900f60c70ce4
Cr-Commit-Position: refs/heads/master@{#418835}