Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227543007: Remove supervised user import command line flags. (Closed)

Created:
6 years, 8 months ago by Adrian Kuegel
Modified:
6 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Remove supervised user import command line flags. This CL removes the allow-create-existing-managed-users and the disable-create-exsting-managed-users flags. BUG=348925 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263255

Patch Set 1 #

Patch Set 2 : Remove last occurrence of flag. #

Total comments: 2

Patch Set 3 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Adrian Kuegel
Pam, can you please review this CL?
6 years, 8 months ago (2014-04-11 08:53:29 UTC) #1
Pam (message me for reviews)
LGTM, one nit https://codereview.chromium.org/227543007/diff/20001/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/227543007/diff/20001/chrome/browser/resources/options/manage_profile_overlay.js#newcode338 chrome/browser/resources/options/manage_profile_overlay.js:338: $('create-profile-managed').checked) { Can this line be ...
6 years, 8 months ago (2014-04-11 13:54:15 UTC) #2
Adrian Kuegel
https://codereview.chromium.org/227543007/diff/20001/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/227543007/diff/20001/chrome/browser/resources/options/manage_profile_overlay.js#newcode338 chrome/browser/resources/options/manage_profile_overlay.js:338: $('create-profile-managed').checked) { On 2014/04/11 13:54:16, Pam (also PM for ...
6 years, 8 months ago (2014-04-11 14:04:56 UTC) #3
Adrian Kuegel
The CQ bit was checked by akuegel@chromium.org
6 years, 8 months ago (2014-04-11 14:05:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/227543007/40001
6 years, 8 months ago (2014-04-11 14:05:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 14:34:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-11 14:34:28 UTC) #7
Adrian Kuegel
The CQ bit was checked by akuegel@chromium.org
6 years, 8 months ago (2014-04-11 14:35:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/227543007/40001
6 years, 8 months ago (2014-04-11 14:37:36 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 16:04:46 UTC) #10
Message was sent while issue was closed. 
Change committed as 263255

Powered by Google App Engine
This is Rietveld 408576698