Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/metrics/histogram.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/measurements/tab_switching.py ('k') | tools/perf/metrics/media.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/histogram.py
===================================================================
--- tools/perf/metrics/histogram.py (revision 217866)
+++ tools/perf/metrics/histogram.py (working copy)
@@ -1,7 +1,9 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+
from metrics import histogram_util
+from telemetry.page import result_data_type
BROWSER_HISTOGRAM = 'browser_histogram'
RENDERER_HISTOGRAM = 'renderer_histogram'
@@ -27,7 +29,7 @@
new_histogram = histogram_util.SubtractHistogram(
data, self._start_values[page.url + self.name])
results.Add(self.name, self.units, new_histogram,
- data_type='unimportant-histogram')
+ data_type=result_data_type.UNIMPORTANT_HISTOGRAM)
@property
def histogram_function(self):
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/measurements/tab_switching.py ('k') | tools/perf/metrics/media.py » ('j') | tools/telemetry/telemetry/page/result_data_type.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698