Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tools/perf/measurements/rasterize_and_record.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/dromaeo.py ('k') | tools/perf/measurements/tab_switching.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/rasterize_and_record.py
===================================================================
--- tools/perf/measurements/rasterize_and_record.py (revision 222891)
+++ tools/perf/measurements/rasterize_and_record.py (working copy)
@@ -5,8 +5,13 @@
import time
from metrics import smoothness
+from telemetry.core import util
from telemetry.page import page_measurement
+# Get build scripts into our path.
+util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'util', 'lib')
+from common import perf_result_data_type # pylint: disable=F0401
+
class StatsCollector(object):
def __init__(self, timeline):
"""
@@ -177,16 +182,16 @@
results.Add('best_rasterize_time', 'seconds',
collector.total_best_rasterize_time / 1.e3,
- data_type='unimportant')
+ data_type=perf_result_data_type.UNIMPORTANT)
results.Add('best_record_time', 'seconds',
collector.total_best_record_time / 1.e3,
- data_type='unimportant')
+ data_type=perf_result_data_type.UNIMPORTANT)
results.Add('total_pixels_rasterized', 'pixels',
collector.total_pixels_rasterized,
- data_type='unimportant')
+ data_type=perf_result_data_type.UNIMPORTANT)
results.Add('total_pixels_recorded', 'pixels',
collector.total_pixels_recorded,
- data_type='unimportant')
+ data_type=perf_result_data_type.UNIMPORTANT)
if self.options.report_all_results:
for k, v in rendering_stats.iteritems():
« no previous file with comments | « tools/perf/measurements/dromaeo.py ('k') | tools/perf/measurements/tab_switching.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698