Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tools/perf/benchmarks/dom_perf.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/perf_tests_helper.py ('k') | tools/perf/benchmarks/kraken.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/dom_perf.py
===================================================================
--- tools/perf/benchmarks/dom_perf.py (revision 222891)
+++ tools/perf/benchmarks/dom_perf.py (working copy)
@@ -11,6 +11,9 @@
from telemetry.page import page_measurement
from telemetry.page import page_set
+# Get build scripts into our path.
+util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'util', 'lib')
+from common import perf_result_data_type # pylint: disable=F0401
def _GeometricMean(values):
"""Compute a rounded geometric mean from an array of values."""
@@ -51,7 +54,8 @@
# Skip benchmarks that we didn't actually run this time around.
if len(suite['Benchmarks']) or suite['score']:
results.Add(SCORE_TRACE_NAME, SCORE_UNIT,
- suite['score'], suite['name'], 'unimportant')
+ suite['score'], suite['name'],
+ perf_result_data_type.UNIMPORTANT)
finally:
tab.EvaluateJavaScript('document.cookie = "__domperf_finished=0"')
« no previous file with comments | « build/android/pylib/perf_tests_helper.py ('k') | tools/perf/benchmarks/kraken.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698