Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/metrics/media.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/measurements/tab_switching.py ('k') | tools/perf/metrics/memory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/media.py
===================================================================
--- tools/perf/metrics/media.py (revision 218037)
+++ tools/perf/metrics/media.py (working copy)
@@ -5,6 +5,7 @@
import os
from metrics import Metric
+from telemetry.page import result_data_type
class MediaMetric(Metric):
"""MediaMetric class injects and calls JS responsible for recording metrics.
@@ -52,7 +53,8 @@
if m.startswith(metric):
special_label = m[len(metric):]
results.Add(trace + special_label, unit, str(metrics[m]),
- chart_name=metric, data_type='default')
+ chart_name=metric,
+ data_type=result_data_type.DEFAULT)
trace = media_metric['id']
if not trace:
« build/android/pylib/perf_tests_helper.py ('K') | « tools/perf/measurements/tab_switching.py ('k') | tools/perf/metrics/memory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698