Refactor BenchmarkResult.Add to take enum for data_type

tools/perf/metrics/memory.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 
 from metrics import histogram_util
 from metrics import Metric
+from telemetry.page import result_data_type
 
 _HISTOGRAMS = [
     {'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent',
      'type': histogram_util.RENDERER_HISTOGRAM},
     {'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb',
      'type': histogram_util.RENDERER_HISTOGRAM},
     {'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb',
      'type': histogram_util.RENDERER_HISTOGRAM},
     {'name': 'Memory.RendererUsed', 'units': 'kb',
      'type': histogram_util.RENDERER_HISTOGRAM},
@@ skipping 45 matching lines @@
           histogram_data, self._histogram_start[h['name']])
 
   def AddResults(self, tab, results):
     """Add results for this page to the results object."""
     assert self._histogram_delta, 'Must call Stop() first'
     for h in _HISTOGRAMS:
       # Histogram data may not be available
       if h['name'] not in self._histogram_start:
         continue
       results.Add(h['name'], h['units'], self._histogram_delta[h['name']],
-                  data_type='unimportant-histogram')
+                  data_type=result_data_type.UNIMPORTANT_HISTOGRAM)
 
   def AddSummaryResults(self, results):
     """Add summary (overall) results to the results object."""
     self._memory_stats = self._browser.memory_stats
     if not self._memory_stats['Browser']:
       return
 
     metric = 'resident_set_size'
     if sys.platform == 'win32':
       metric = 'working_set'
@@ skipping 14 matching lines @@
         """
         if len(process_types_memory) > 1 and value_name_memory.endswith('Peak'):
           return
         values = []
         for process_type_memory in process_types_memory:
           stats = self._memory_stats[process_type_memory]
           if value_name_memory in stats:
             values.append(stats[value_name_memory])
         if values:
           results.AddSummary(value_name_trace + process_type_trace,
-                             'bytes', sum(values), data_type='unimportant')
+                             'bytes', sum(values),
+                             data_type=result_data_type.UNIMPORTANT_HISTOGRAM)
 
       AddSummary('VM', 'vm_final_size_')
       AddSummary('WorkingSetSize', 'vm_%s_final_size_' % metric)
       AddSummary('PrivateDirty', 'vm_private_dirty_final_')
       AddSummary('ProportionalSetSize', 'vm_proportional_set_size_final_')
       AddSummary('VMPeak', 'vm_peak_size_')
       AddSummary('WorkingSetSizePeak', '%s_peak_size_' % metric)
 
     AddSummariesForProcessTypes(['Browser'], 'browser')
     AddSummariesForProcessTypes(['Renderer'], 'renderer')
     AddSummariesForProcessTypes(['Gpu'], 'gpu')
     AddSummariesForProcessTypes(['Browser', 'Renderer', 'Gpu'], 'total')
 
     end_commit_charge = self._memory_stats['SystemCommitCharge']
     commit_charge_difference = end_commit_charge - self._start_commit_charge
     results.AddSummary('commit_charge', 'kb', commit_charge_difference,
-                       data_type='unimportant')
+                       data_type=result_data_type.UNIMPORTANT)
     results.AddSummary('processes', 'count', self._memory_stats['ProcessCount'],
-                       data_type='unimportant')
+                       data_type=result_data_type.UNIMPORTANT)