third_party/WebKit/Source/web/mac/WebSubstringUtil.mm - Issue 2275323003: Fix position of dictionary pop-up for <iframe>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 2275323003: Fix position of dictionary pop-up for <iframe>. (Closed)

Patch Set: Added a WebViewTest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

index aee528403806d9ba04e35ccc39f86ea209b24889..c32db74669ef2c763a1399629e7f4166298cc9fb 100644

--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

@@ -123,7 +123,7 @@ WebPoint getBaselinePoint(FrameView* frameView, const EphemeralRange& range, NSA

// TODO(shuchen): Support page-zoom for getting the baseline point.

IntRect stringRect = frameView->contentsToRootFrame(createRange(range)->boundingBox());

IntPoint stringPoint = stringRect.minXMaxYCorner();

- stringPoint.setY(frameView->height() - stringPoint.y());

+ stringPoint.setY(frameView->root()->height() - stringPoint.y());

// Adjust for the font's descender. AppKit wants the baseline point.

if ([string length]) {