Fix position of dictionary pop-up for <iframe>.

third_party/WebKit/Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 3180 matching lines @@
 
     webView->setZoomLevel(3);
 
     result = WebSubstringUtil::attributedSubstringInRange(frame, 5, 5, &baselinePoint);
     ASSERT_TRUE(!!result);
 
     point = WebPoint(baselinePoint.x, frameView->height() - baselinePoint.y);
     result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
     ASSERT_TRUE(!!result);
 }
+
+TEST_F(WebViewTest, WebSubstringUtilIframe)
+{
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("single_iframe.html"));
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("visible_iframe.html"));

[bokan, 2016/08/26 19:10:31]

I don't think you have to register iframe loads but I could be wrong. See if it
works without this line.

[EhsanK, 2016/08/26 20:14:48]

Unfortunately, I can't remove it since this CHECK will fire if I do:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/testi...

[bokan, 2016/08/26 20:23:19]

Ok, it's fine as-is, thanks for trying.

+    WebViewImpl* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "single_iframe.html");
+    webView->settings()->setDefaultFontSize(12);
+    webView->settings()->setJavaScriptEnabled(true);
+    webView->resize(WebSize(400, 400));
+    WebLocalFrameImpl* mainFrame = webView->mainFrameImpl();
+    WebLocalFrameImpl* childFrame = WebLocalFrameImpl::fromFrame(toLocalFrame(mainFrame->frame()->tree().firstChild()));
+
+    WebPoint baselinePoint;
+    NSAttributedString* result = WebSubstringUtil::attributedSubstringInRange(childFrame, 11, 7, &baselinePoint);
+    ASSERT_TRUE(!!result);

[bokan, 2016/08/26 19:10:31]

Nit: no double-bang needed. Even better: ASSERT_NE(result, nullptr)

[EhsanK, 2016/08/26 20:14:48]

Thanks! Done.

+
+    WebPoint point(baselinePoint.x, mainFrame->frameView()->height() - baselinePoint.y);
+    result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+    ASSERT_TRUE(!!result);
+
+    int yBeforeChange = baselinePoint.y;
+
+    // Now move the <iframe> down by 100px.
+    mainFrame->executeScript(WebScriptSource(
+        "document.querySelector('iframe').style.marginTop = '100px';"));
+
+    point = WebPoint(point.x, point.y + 100);
+    result = WebSubstringUtil::attributedWordAtPoint(webView, point, baselinePoint);
+    ASSERT_TRUE(!!result);
+
+    EXPECT_EQ(yBeforeChange, baselinePoint.y + 100);
+}
+
 #endif
 
 TEST_F(WebViewTest, PasswordFieldEditingIsUserGesture)
 {
     URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("input_field_password.html"));
     MockAutofillClient client;
     WebViewImpl* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "input_field_password.html", true);
     WebLocalFrameImpl* frame = webView->mainFrameImpl();
     frame->setAutofillClient(&client);
     webView->setInitialFocus(false);
@@ skipping 69 matching lines @@
             EXPECT_TRUE(webView->page()->defersLoading());
         }
 
         EXPECT_TRUE(webView->page()->defersLoading());
     }
 
     EXPECT_FALSE(webView->page()->defersLoading());
 }
 
 } // namespace blink