Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ios/web/shell/test/earl_grey/shell_matchers.h

Issue 2275303004: Context menu egtests, plus related utilities. (Closed)
Patch Set: Review feedback plus some fixes and tweaks. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/shell/test/earl_grey/shell_matchers.h
diff --git a/ios/web/shell/test/earl_grey/shell_matchers.h b/ios/web/shell/test/earl_grey/shell_matchers.h
index f458b8c60ad6f462b65e44c1724329b70de6e0cf..9b82f772fa6e7c4ec9a5e7e9618c57817a089f0b 100644
--- a/ios/web/shell/test/earl_grey/shell_matchers.h
+++ b/ios/web/shell/test/earl_grey/shell_matchers.h
@@ -2,23 +2,29 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#import <string>
+#ifndef IOS_WEB_SHELL_TEST_EARL_GREY_SHELL_MATCHERS_H_
+#define IOS_WEB_SHELL_TEST_EARL_GREY_SHELL_MATCHERS_H_
+
+#include <string>
#import <EarlGrey/EarlGrey.h>
namespace web {
// Matcher for WKWebView containing |text|.
-id<GREYMatcher> webViewContainingText(std::string text);
+id<GREYMatcher> webViewContainingText(const std::string& text);
// Matcher for WKWebView containing an html element which matches |selector|.
-id<GREYMatcher> webViewCssSelector(std::string selector);
+id<GREYMatcher> webViewCssSelector(const std::string& selector);
+
+// Matcher for the WKWebView.
+id<GREYMatcher> webView();
// Matcher for WKWebView's scroll view.
id<GREYMatcher> webViewScrollView();
// Matcher for web shell address field text property equal to |text|.
-id<GREYMatcher> addressFieldText(std::string text);
+id<GREYMatcher> addressFieldText(const std::string& text);
// Matcher for back button in web shell.
id<GREYMatcher> backButton();
@@ -30,3 +36,5 @@ id<GREYMatcher> forwardButton();
id<GREYMatcher> addressField();
} // namespace web
+
+#endif // IOS_WEB_SHELL_TEST_EARL_GREY_SHELL_MATCHERS_H_

Powered by Google App Engine
This is Rietveld 408576698