Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: ios/web/public/test/earl_grey/web_view_matchers.h

Issue 2275303004: Context menu egtests, plus related utilities. (Closed)
Patch Set: Review feedback plus some fixes and tweaks. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/earl_grey/web_view_matchers.h
diff --git a/ios/web/public/test/earl_grey/web_view_matchers.h b/ios/web/public/test/earl_grey/web_view_matchers.h
index 70e05e5bedf847df31eb019942f08f6bdf21def7..ec7e52cbbc10bee5772ce3a0a95fd8a73316d947 100644
--- a/ios/web/public/test/earl_grey/web_view_matchers.h
+++ b/ios/web/public/test/earl_grey/web_view_matchers.h
@@ -2,7 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#import <string>
+#ifndef IOS_WEB_PUBLIC_TEST_EARL_GREY_WEB_VIEW_MATCHERS_H_
+#define IOS_WEB_PUBLIC_TEST_EARL_GREY_WEB_VIEW_MATCHERS_H_
+
+#include <string>
#import <EarlGrey/EarlGrey.h>
@@ -14,18 +17,22 @@ namespace web {
id<GREYMatcher> webViewInWebState(WebState* web_state);
// Matcher for WKWebView containing |text|.
-id<GREYMatcher> webViewContainingText(std::string text, WebState* web_state);
+id<GREYMatcher> webViewContainingText(const std::string& text,
+ WebState* web_state);
// Matcher for WKWebView containing a blocked |image_id|. When blocked, the
// image will be smaller than |expected_size|.
-id<GREYMatcher> webViewContainingBlockedImage(std::string image_id,
+id<GREYMatcher> webViewContainingBlockedImage(const std::string& image_id,
CGSize expected_size,
WebState* web_state);
// Matcher for WKWebView containing an html element which matches |selector|.
-id<GREYMatcher> webViewCssSelector(std::string selector, WebState* web_state);
+id<GREYMatcher> webViewCssSelector(const std::string& selector,
+ WebState* web_state);
// Matcher for WKWebView's scroll view.
id<GREYMatcher> webViewScrollView(WebState* web_state);
} // namespace web
+
+#endif // IOS_WEB_PUBLIC_TEST_EARL_GREY_WEB_VIEW_MATCHERS_H_

Powered by Google App Engine
This is Rietveld 408576698