Context menu egtests, plus related utilities.

ios/web/public/test/earl_grey/web_view_actions.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_WEB_PUBLIC_TEST_EARL_GREY_WEB_VIEW_ACTIONS_H_
+#define IOS_WEB_PUBLIC_TEST_EARL_GREY_WEB_VIEW_ACTIONS_H_
+
+#import <string>

[Eugene But (OOO till 7-30), 2016/08/30 18:11:04]

s/import/include

[marq (ping after 24h), 2016/08/31 13:07:57]

Done.

+
+#import <EarlGrey/EarlGrey.h>
+
+#import "ios/web/public/web_state/web_state.h"
+
+namespace web {
+
+// Action wrapper that performs |action| on the webview of |state|.
+// The action will fail (in addition to its own failure modes) if |element_id|
+// can't be located, or if it doesn't trigger a mousedown event on |element_id|
+// inside the webview.
+id<GREYAction> webViewVerifiedActionOnElement(WebState* state,
+                                              id<GREYAction> action,
+                                              std::string element_id);

[Eugene But (OOO till 7-30), 2016/08/30 18:11:04]

const std::string& ?

[marq (ping after 24h), 2016/08/31 13:07:57]

Done.

+
+// Executes a longpress on element |element_id| in the webview of
+// |state|. If |triggers_context_menu| is true, this gesture is expected to
+// cause the context menu to appear, and is not expected to trigger events
+// in the webview. If |triggers_context_menu| is false, the converse is true.
+// This action doesn't fail if the context menu isn't displayed; calling code
+// should check for that separately with a matcher.
+void LongPressWebViewElementForContextMenu(WebState* state,

[Eugene But (OOO till 7-30), 2016/08/30 18:11:04]

Is there a reason why this is not inside web_view_interaction_test_util.h? 

Feels similar to TapWebViewElementWithId and is not actually GREYAction.

[marq (ping after 24h), 2016/08/31 13:07:57]

Yeah, the problem is that web_view_interaction_test_util doesn't depend on EG at
all, and the functions there don't (for example) throw EG assertions, and this
does. I'll see if I can make it into an action instead.

+                                           std::string element_id,
+                                           bool triggers_context_menu);
+
+}  // namespace web
+
+#endif  // IOS_WEB_PUBLIC_TEST_EARL_GREY_WEB_VIEW_ACTIONS_H_