Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 2275253003: Fix jank on Android due to bad scheduler deadline (Closed)

Created:
4 years, 3 months ago by enne (OOO)
Modified:
4 years, 3 months ago
Reviewers:
no sievers
CC:
aelias_OOO_until_Jul13, chromium-reviews, darin-cc_chromium.org, jam, vmiura
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix jank on Android due to bad scheduler deadline https://codereview.chromium.org/1821863002 changed the display scheduler on Android to use the CompositorImpl ExternalBeginFrameSource directly instead of a synthetic BeginFrameSource that had its vsync parameters set from WindowAndroidCompositor::OnVSync. The frame time given to the display scheduler is always in the past, which made the past logic always give an immediate deadline, causing the display scheduler to run immediately. Fix this by providing a correct deadline in the future. This fixes bad jank where the display scheduler would never give any other compositors time to give frames. So, if the browser compositor was producing frames (such as a loading spinner) then the renderer frames would be extremely janky as they would often miss the immediate (incorrect) deadline. BUG=613193 R=sievers@chromium.org Committed: https://crrev.com/ab408ac5e81ddf37772a9410cec2b7f747973a2d Cr-Commit-Position: refs/heads/master@{#414765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
enne (OOO)
4 years, 3 months ago (2016-08-26 00:38:15 UTC) #2
no sievers
lgtm
4 years, 3 months ago (2016-08-26 18:00:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275253003/1
4 years, 3 months ago (2016-08-26 18:05:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 18:52:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:16:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab408ac5e81ddf37772a9410cec2b7f747973a2d
Cr-Commit-Position: refs/heads/master@{#414765}

Powered by Google App Engine
This is Rietveld 408576698