Ignore fill when stroke & filling convex line-only paths

Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and fill path remaining convex. There seems to be an issue with round joins where the outer generated shell is usually not convex. Without this CL the resulting stroke & filled paths are always concave.

Perf-wise (on Windows):

convex-lineonly-paths-stroke-and-fill bench

(in ms)   w/o   w/CL    %decrease

8888      2.88  2.01      30.2

gpu       4.4   1.38      68.6

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003

Committed: https://skia.googlesource.com/skia/+/ad2344693c70f13d5e4216df8458b4d907395bde

[robertphillips, 2016-08-25 18:55:06]

Description was changed from

==========
Ignore fill when stroke & filling convex line-only paths
==========

to

==========
Ignore fill when stroke & filling convex line-only paths
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

[robertphillips, 2016-08-25 21:04:48]

Description was changed from

==========
Ignore fill when stroke & filling convex line-only paths
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

to

==========
Ignore fill when stroke & filling convex line-only paths
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

[robertphillips, 2016-08-25 21:04:48]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-08-25 21:57:39]

Description was changed from

==========
Ignore fill when stroke & filling convex line-only paths
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

to

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

[robertphillips, 2016-08-25 21:58:41]

Description was changed from

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

to

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex. Without this CL the resulting
stroke & filled paths are always concave.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

[robertphillips, 2016-08-25 22:04:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:04:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:31:29]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-08-26 01:24:25]

lgtm, I wonder if the round concavities are related to small conic/quadratics
(skbug.com/5672)

https://codereview.chromium.org/2275243003/diff/60001/src/core/SkStroke.cpp
File src/core/SkStroke.cpp (right):

https://codereview.chromium.org/2275243003/diff/60001/src/core/SkStroke.cpp#n...
src/core/SkStroke.cpp:1355: return  (p.getSegmentMasks() & 
SkPath::kLine_SegmentMask) &&
Is this different than p.getSegmentMasks() == SkPath::kLine_SegmentMask?

[robertphillips, 2016-08-26 11:44:32]

I'm going to look into the concavity issue this morning. I suspect the round
caps are a bit too peaked.

https://codereview.chromium.org/2275243003/diff/60001/src/core/SkStroke.cpp
File src/core/SkStroke.cpp (right):

https://codereview.chromium.org/2275243003/diff/60001/src/core/SkStroke.cpp#n...
src/core/SkStroke.cpp:1355: return  (p.getSegmentMasks() & 
SkPath::kLine_SegmentMask) &&
On 2016/08/26 01:24:25, bsalomon wrote:
> Is this different than p.getSegmentMasks() == SkPath::kLine_SegmentMask?

Haha - no! Fixed.

[robertphillips, 2016-08-26 11:44:49]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 11:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-26 11:56:31]

Description was changed from

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex. Without this CL the resulting
stroke & filled paths are always concave.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

to

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex. Without this CL the resulting
stroke & filled paths are always concave.

Perf-wise (on Windows):

convex-lineonly-paths-stroke-and-fill bench

(in ms)   w/o   w/CL    %decrease

8888      2.88  2.01      30.2

gpu       4.4   1.38      68.6

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

[commit-bot: I haz the power, 2016-08-26 12:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 12:10:49]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-26 12:29:21]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-08-26 12:29:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2275243003/#ps80001
(title: "Fix mistake")

[commit-bot: I haz the power, 2016-08-26 12:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 12:30:22]

Description was changed from

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex. Without this CL the resulting
stroke & filled paths are always concave.

Perf-wise (on Windows):

convex-lineonly-paths-stroke-and-fill bench

(in ms)   w/o   w/CL    %decrease

8888      2.88  2.01      30.2

gpu       4.4   1.38      68.6

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003
==========

to

==========
Ignore fill when stroke & filling convex line-only paths

This seems to work well for miter and bevel joins with the resulting stroke and
fill path remaining convex. There seems to be an issue with round joins where
the outer generated shell is usually not convex. Without this CL the resulting
stroke & filled paths are always concave.

Perf-wise (on Windows):

convex-lineonly-paths-stroke-and-fill bench

(in ms)   w/o   w/CL    %decrease

8888      2.88  2.01      30.2

gpu       4.4   1.38      68.6

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275243003

Committed:
https://skia.googlesource.com/skia/+/ad2344693c70f13d5e4216df8458b4d907395bde
==========

[commit-bot: I haz the power, 2016-08-26 12:30:23]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/ad2344693c70f13d5e4216df8458b4d907395bde