Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: src/execution.cc

Issue 2275233002: Refactor call site handling for stack formatting (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/execution.h ('k') | src/heap-symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/execution.cc
diff --git a/src/execution.cc b/src/execution.cc
index c42d1646033951fc4731f090eba5d2c5f9bc8065..6936641cb5ee138cbeb4d671156cd0fff79199aa 100644
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -436,31 +436,6 @@ void StackGuard::InitThread(const ExecutionAccess& lock) {
// --- C a l l s t o n a t i v e s ---
-Handle<String> Execution::GetStackTraceLine(Handle<Object> recv,
- Handle<JSFunction> fun,
- Handle<Object> pos,
- Handle<Object> is_global) {
- Isolate* isolate = fun->GetIsolate();
- Handle<Object> strict_mode = isolate->factory()->ToBoolean(false);
-
- MaybeHandle<Object> maybe_callsite =
- CallSiteUtils::Construct(isolate, recv, fun, pos, strict_mode);
- if (maybe_callsite.is_null()) {
- isolate->clear_pending_exception();
- return isolate->factory()->empty_string();
- }
-
- MaybeHandle<String> maybe_to_string =
- CallSiteUtils::ToString(isolate, maybe_callsite.ToHandleChecked());
- if (maybe_to_string.is_null()) {
- isolate->clear_pending_exception();
- return isolate->factory()->empty_string();
- }
-
- return maybe_to_string.ToHandleChecked();
-}
-
-
void StackGuard::HandleGCInterrupt() {
if (CheckAndClearInterrupt(GC_REQUEST)) {
isolate_->heap()->HandleGCRequest();
« no previous file with comments | « src/execution.h ('k') | src/heap-symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698