Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 227523003: Only enforce the strongest SettingsEnforcement group in the absence of a Finch config on Windows. (Closed)

Created:
6 years, 8 months ago by gab
Modified:
6 years, 8 months ago
Reviewers:
robertshield
CC:
chromium-reviews, erikwright (departed)
Visibility:
Public.

Description

Only enforce the strongest SettingsEnforcement group in the absence of a Finch config on Windows. BUG=361778 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263029

Patch Set 1 #

Total comments: 2

Patch Set 2 : GROUP_NO_ENFORCEMENT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
Robert, PTAL. Thanks! Gab
6 years, 8 months ago (2014-04-09 21:30:18 UTC) #1
robertshield
https://codereview.chromium.org/227523003/diff/1/chrome/browser/prefs/chrome_pref_service_factory.cc File chrome/browser/prefs/chrome_pref_service_factory.cc (right): https://codereview.chromium.org/227523003/diff/1/chrome/browser/prefs/chrome_pref_service_factory.cc#newcode213 chrome/browser/prefs/chrome_pref_service_factory.cc:213: NO_ENFORCEMENT; GROUP_NO_ENFORCEMENT?
6 years, 8 months ago (2014-04-09 23:26:21 UTC) #2
gab
https://codereview.chromium.org/227523003/diff/1/chrome/browser/prefs/chrome_pref_service_factory.cc File chrome/browser/prefs/chrome_pref_service_factory.cc (right): https://codereview.chromium.org/227523003/diff/1/chrome/browser/prefs/chrome_pref_service_factory.cc#newcode213 chrome/browser/prefs/chrome_pref_service_factory.cc:213: NO_ENFORCEMENT; On 2014/04/09 23:26:21, robertshield wrote: > GROUP_NO_ENFORCEMENT? Duh, ...
6 years, 8 months ago (2014-04-10 13:15:25 UTC) #3
robertshield
lgtm
6 years, 8 months ago (2014-04-10 16:57:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/227523003/20001
6 years, 8 months ago (2014-04-10 16:58:08 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 18:20:10 UTC) #6
Message was sent while issue was closed.
Change committed as 263029

Powered by Google App Engine
This is Rietveld 408576698