gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h - Issue 2275203002: Make command buffer commands and immediate data volatile

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h

Issue 2275203002: Make command buffer commands and immediate data volatile (Closed)

Patch Set: std::copy->const_cast+memcpy Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h

index 0a97b2af2e922e1a3874a842662afd8be16df4a2..c5cb28bb88d097a1dffcd61857fb2bc489f1c049 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h

@@ -46,13 +46,13 @@ error::Error DoClearBufferfi(GLenum buffer,

GLint stencil);

error::Error DoClearBufferfv(GLenum buffer,

GLint drawbuffers,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoClearBufferiv(GLenum buffer,

GLint drawbuffers,

- const GLint* value);

+ const volatile GLint* value);

error::Error DoClearBufferuiv(GLenum buffer,

GLint drawbuffers,

- const GLuint* value);

+ const volatile GLuint* value);

error::Error DoClearColor(GLclampf red,

GLclampf green,

GLclampf blue,

@@ -138,15 +138,17 @@ error::Error DoCopyTexSubImage3D(GLenum target,

error::Error DoCreateProgram(GLuint client_id);

error::Error DoCreateShader(GLenum type, GLuint client_id);

error::Error DoCullFace(GLenum mode);

-error::Error DoDeleteBuffers(GLsizei n, const GLuint* buffers);

-error::Error DoDeleteFramebuffers(GLsizei n, const GLuint* framebuffers);

+error::Error DoDeleteBuffers(GLsizei n, const volatile GLuint* buffers);

+error::Error DoDeleteFramebuffers(GLsizei n,

+ const volatile GLuint* framebuffers);

error::Error DoDeleteProgram(GLuint program);

-error::Error DoDeleteRenderbuffers(GLsizei n, const GLuint* renderbuffers);

-error::Error DoDeleteSamplers(GLsizei n, const GLuint* samplers);

+error::Error DoDeleteRenderbuffers(GLsizei n,

+ const volatile GLuint* renderbuffers);

+error::Error DoDeleteSamplers(GLsizei n, const volatile GLuint* samplers);

error::Error DoDeleteSync(GLuint sync);

error::Error DoDeleteShader(GLuint shader);

-error::Error DoDeleteTextures(GLsizei n, const GLuint* textures);

-error::Error DoDeleteTransformFeedbacks(GLsizei n, const GLuint* ids);

+error::Error DoDeleteTextures(GLsizei n, const volatile GLuint* textures);

+error::Error DoDeleteTransformFeedbacks(GLsizei n, const volatile GLuint* ids);

error::Error DoDepthFunc(GLenum func);

error::Error DoDepthMask(GLboolean flag);

error::Error DoDepthRangef(GLclampf zNear, GLclampf zFar);

@@ -178,13 +180,13 @@ error::Error DoFramebufferTextureLayer(GLenum target,

GLint level,

GLint layer);

error::Error DoFrontFace(GLenum mode);

-error::Error DoGenBuffers(GLsizei n, GLuint* buffers);

+error::Error DoGenBuffers(GLsizei n, volatile GLuint* buffers);

error::Error DoGenerateMipmap(GLenum target);

-error::Error DoGenFramebuffers(GLsizei n, GLuint* framebuffers);

-error::Error DoGenRenderbuffers(GLsizei n, GLuint* renderbuffers);

-error::Error DoGenSamplers(GLsizei n, GLuint* samplers);

-error::Error DoGenTextures(GLsizei n, GLuint* textures);

-error::Error DoGenTransformFeedbacks(GLsizei n, GLuint* ids);

+error::Error DoGenFramebuffers(GLsizei n, volatile GLuint* framebuffers);

+error::Error DoGenRenderbuffers(GLsizei n, volatile GLuint* renderbuffers);

+error::Error DoGenSamplers(GLsizei n, volatile GLuint* samplers);

+error::Error DoGenTextures(GLsizei n, volatile GLuint* textures);

+error::Error DoGenTransformFeedbacks(GLsizei n, volatile GLuint* ids);

error::Error DoGetActiveAttrib(GLuint program,

GLuint index,

GLint* size,

@@ -378,10 +380,10 @@ error::Error DoGetVertexAttribPointerv(GLuint index,

error::Error DoHint(GLenum target, GLenum mode);

error::Error DoInvalidateFramebuffer(GLenum target,

GLsizei count,

- const GLenum* attachments);

+ const volatile GLenum* attachments);

error::Error DoInvalidateSubFramebuffer(GLenum target,

GLsizei count,

- const GLenum* attachments,

+ const volatile GLenum* attachments,

GLint x,

GLint y,

GLsizei width,

@@ -421,11 +423,11 @@ error::Error DoSampleCoverage(GLclampf value, GLboolean invert);

error::Error DoSamplerParameterf(GLuint sampler, GLenum pname, GLfloat param);

error::Error DoSamplerParameterfv(GLuint sampler,

GLenum pname,

- const GLfloat* params);

+ const volatile GLfloat* params);

error::Error DoSamplerParameteri(GLuint sampler, GLenum pname, GLint param);

error::Error DoSamplerParameteriv(GLuint sampler,

GLenum pname,

- const GLint* params);

+ const volatile GLint* params);

error::Error DoScissor(GLint x, GLint y, GLsizei width, GLsizei height);

error::Error DoShaderBinary(GLsizei n,

const GLuint* shaders,

@@ -472,9 +474,11 @@ error::Error DoTexImage3D(GLenum target,

error::Error DoTexParameterf(GLenum target, GLenum pname, GLfloat param);

error::Error DoTexParameterfv(GLenum target,

GLenum pname,

- const GLfloat* params);

+ const volatile GLfloat* params);

error::Error DoTexParameteri(GLenum target, GLenum pname, GLint param);

-error::Error DoTexParameteriv(GLenum target, GLenum pname, const GLint* params);

+error::Error DoTexParameteriv(GLenum target,

+ GLenum pname,

+ const volatile GLint* params);

error::Error DoTexStorage3D(GLenum target,

GLsizei levels,

GLenum internalFormat,

@@ -508,98 +512,122 @@ error::Error DoTransformFeedbackVaryings(GLuint program,

const char** varyings,

GLenum buffermode);

error::Error DoUniform1f(GLint location, GLfloat x);

-error::Error DoUniform1fv(GLint location, GLsizei count, const GLfloat* v);

+error::Error DoUniform1fv(GLint location,

+ GLsizei count,

+ const volatile GLfloat* v);

error::Error DoUniform1i(GLint location, GLint x);

-error::Error DoUniform1iv(GLint location, GLsizei count, const GLint* v);

+error::Error DoUniform1iv(GLint location,

+ GLsizei count,

+ const volatile GLint* v);

error::Error DoUniform1ui(GLint location, GLuint x);

-error::Error DoUniform1uiv(GLint location, GLsizei count, const GLuint* v);

+error::Error DoUniform1uiv(GLint location,

+ GLsizei count,

+ const volatile GLuint* v);

error::Error DoUniform2f(GLint location, GLfloat x, GLfloat y);

-error::Error DoUniform2fv(GLint location, GLsizei count, const GLfloat* v);

+error::Error DoUniform2fv(GLint location,

+ GLsizei count,

+ const volatile GLfloat* v);

error::Error DoUniform2i(GLint location, GLint x, GLint y);

-error::Error DoUniform2iv(GLint location, GLsizei count, const GLint* v);

+error::Error DoUniform2iv(GLint location,

+ GLsizei count,

+ const volatile GLint* v);

error::Error DoUniform2ui(GLint location, GLuint x, GLuint y);

-error::Error DoUniform2uiv(GLint location, GLsizei count, const GLuint* v);

+error::Error DoUniform2uiv(GLint location,

+ GLsizei count,

+ const volatile GLuint* v);

error::Error DoUniform3f(GLint location, GLfloat x, GLfloat y, GLfloat z);

-error::Error DoUniform3fv(GLint location, GLsizei count, const GLfloat* v);

+error::Error DoUniform3fv(GLint location,

+ GLsizei count,

+ const volatile GLfloat* v);

error::Error DoUniform3i(GLint location, GLint x, GLint y, GLint z);

-error::Error DoUniform3iv(GLint location, GLsizei count, const GLint* v);

+error::Error DoUniform3iv(GLint location,

+ GLsizei count,

+ const volatile GLint* v);

error::Error DoUniform3ui(GLint location, GLuint x, GLuint y, GLuint z);

-error::Error DoUniform3uiv(GLint location, GLsizei count, const GLuint* v);

+error::Error DoUniform3uiv(GLint location,

+ GLsizei count,

+ const volatile GLuint* v);

error::Error DoUniform4f(GLint location,

GLfloat x,

GLfloat y,

GLfloat z,

GLfloat w);

-error::Error DoUniform4fv(GLint location, GLsizei count, const GLfloat* v);

+error::Error DoUniform4fv(GLint location,

+ GLsizei count,

+ const volatile GLfloat* v);

error::Error DoUniform4i(GLint location, GLint x, GLint y, GLint z, GLint w);

-error::Error DoUniform4iv(GLint location, GLsizei count, const GLint* v);

+error::Error DoUniform4iv(GLint location,

+ GLsizei count,

+ const volatile GLint* v);

error::Error DoUniform4ui(GLint location,

GLuint x,

GLuint y,

GLuint z,

GLuint w);

-error::Error DoUniform4uiv(GLint location, GLsizei count, const GLuint* v);

+error::Error DoUniform4uiv(GLint location,

+ GLsizei count,

+ const volatile GLuint* v);

error::Error DoUniformBlockBinding(GLuint program,

GLuint index,

GLuint binding);

error::Error DoUniformMatrix2fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix2x3fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix2x4fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix3fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix3x2fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix3x4fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix4fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix4x2fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUniformMatrix4x3fv(GLint location,

GLsizei count,

GLboolean transpose,

- const GLfloat* value);

+ const volatile GLfloat* value);

error::Error DoUseProgram(GLuint program);

error::Error DoValidateProgram(GLuint program);

error::Error DoVertexAttrib1f(GLuint indx, GLfloat x);

-error::Error DoVertexAttrib1fv(GLuint indx, const GLfloat* values);

+error::Error DoVertexAttrib1fv(GLuint indx, const volatile GLfloat* values);

error::Error DoVertexAttrib2f(GLuint indx, GLfloat x, GLfloat y);

-error::Error DoVertexAttrib2fv(GLuint indx, const GLfloat* values);

+error::Error DoVertexAttrib2fv(GLuint indx, const volatile GLfloat* values);

error::Error DoVertexAttrib3f(GLuint indx, GLfloat x, GLfloat y, GLfloat z);

-error::Error DoVertexAttrib3fv(GLuint indx, const GLfloat* values);

+error::Error DoVertexAttrib3fv(GLuint indx, const volatile GLfloat* values);

error::Error DoVertexAttrib4f(GLuint indx,

GLfloat x,

GLfloat y,

GLfloat z,

GLfloat w);

-error::Error DoVertexAttrib4fv(GLuint indx, const GLfloat* values);

+error::Error DoVertexAttrib4fv(GLuint indx, const volatile GLfloat* values);

error::Error DoVertexAttribI4i(GLuint indx, GLint x, GLint y, GLint z, GLint w);

-error::Error DoVertexAttribI4iv(GLuint indx, const GLint* values);

+error::Error DoVertexAttribI4iv(GLuint indx, const volatile GLint* values);

error::Error DoVertexAttribI4ui(GLuint indx,

GLuint x,

GLuint y,

GLuint z,

GLuint w);

-error::Error DoVertexAttribI4uiv(GLuint indx, const GLuint* values);

+error::Error DoVertexAttribI4uiv(GLuint indx, const volatile GLuint* values);

error::Error DoVertexAttribIPointer(GLuint indx,

GLint size,

GLenum type,

@@ -644,8 +672,8 @@ error::Error DoTexStorage2DEXT(GLenum target,

GLenum internalFormat,

GLsizei width,

GLsizei height);

-error::Error DoGenQueriesEXT(GLsizei n, GLuint* queries);

-error::Error DoDeleteQueriesEXT(GLsizei n, const GLuint* queries);

+error::Error DoGenQueriesEXT(GLsizei n, volatile GLuint* queries);

+error::Error DoDeleteQueriesEXT(GLsizei n, const volatile GLuint* queries);

error::Error DoQueryCounterEXT(GLuint id, GLenum target);

error::Error DoBeginQueryEXT(GLenum target, GLuint id);

error::Error DoBeginTransformFeedback(GLenum primitivemode);

@@ -655,8 +683,8 @@ error::Error DoSetDisjointValueSyncCHROMIUM(DisjointValueSync* sync);

error::Error DoInsertEventMarkerEXT(GLsizei length, const char* marker);

error::Error DoPushGroupMarkerEXT(GLsizei length, const char* marker);

error::Error DoPopGroupMarkerEXT();

-error::Error DoGenVertexArraysOES(GLsizei n, GLuint* arrays);

-error::Error DoDeleteVertexArraysOES(GLsizei n, const GLuint* arrays);

+error::Error DoGenVertexArraysOES(GLsizei n, volatile GLuint* arrays);

+error::Error DoDeleteVertexArraysOES(GLsizei n, const volatile GLuint* arrays);

error::Error DoIsVertexArrayOES(GLuint array, uint32_t* result);

error::Error DoBindVertexArrayOES(GLuint array);

error::Error DoSwapBuffers();

@@ -721,14 +749,16 @@ error::Error DoDrawElementsInstancedANGLE(GLenum mode,

const void* indices,

GLsizei primcount);

error::Error DoVertexAttribDivisorANGLE(GLuint index, GLuint divisor);

-error::Error DoProduceTextureCHROMIUM(GLenum target, const GLbyte* mailbox);

+error::Error DoProduceTextureCHROMIUM(GLenum target,

+ const volatile GLbyte* mailbox);

error::Error DoProduceTextureDirectCHROMIUM(GLuint texture,

GLenum target,

- const GLbyte* mailbox);

-error::Error DoConsumeTextureCHROMIUM(GLenum target, const GLbyte* mailbox);

+ const volatile GLbyte* mailbox);

+error::Error DoConsumeTextureCHROMIUM(GLenum target,

+ const volatile GLbyte* mailbox);

error::Error DoCreateAndConsumeTextureINTERNAL(GLenum target,

GLuint texture,

- const GLbyte* mailbox);

+ const volatile GLbyte* mailbox);

error::Error DoBindUniformLocationCHROMIUM(GLuint program,

GLint location,

const char* name);

@@ -739,14 +769,14 @@ error::Error DoTraceBeginCHROMIUM(const char* category_name,

error::Error DoTraceEndCHROMIUM();

error::Error DoDiscardFramebufferEXT(GLenum target,

GLsizei count,

- const GLenum* attachments);

+ const volatile GLenum* attachments);

error::Error DoLoseContextCHROMIUM(GLenum current, GLenum other);

error::Error DoDescheduleUntilFinishedCHROMIUM();

error::Error DoInsertFenceSyncCHROMIUM(GLuint64 release_count);

error::Error DoWaitSyncTokenCHROMIUM(CommandBufferNamespace namespace_id,

CommandBufferId command_buffer_id,

GLuint64 release_count);

-error::Error DoDrawBuffersEXT(GLsizei count, const GLenum* bufs);

+error::Error DoDrawBuffersEXT(GLsizei count, const volatile GLenum* bufs);

error::Error DoDiscardBackbufferCHROMIUM();

error::Error DoScheduleOverlayPlaneCHROMIUM(GLint plane_z_order,

GLenum plane_transform,

@@ -769,12 +799,14 @@ error::Error DoScheduleCALayerCHROMIUM(GLuint contents_texture_id,

GLuint background_color,

GLuint edge_aa_mask,

const GLfloat* bounds_rect);

-error::Error DoScheduleCALayerInUseQueryCHROMIUM(GLuint n,

- const GLuint* textures);

+error::Error DoScheduleCALayerInUseQueryCHROMIUM(

+ GLuint n,

+ const volatile GLuint* textures);

error::Error DoCommitOverlayPlanesCHROMIUM();

error::Error DoSwapInterval(GLint interval);

error::Error DoFlushDriverCachesCHROMIUM();

-error::Error DoMatrixLoadfCHROMIUM(GLenum matrixMode, const GLfloat* m);

+error::Error DoMatrixLoadfCHROMIUM(GLenum matrixMode,

+ const volatile GLfloat* m);

error::Error DoMatrixLoadIdentityCHROMIUM(GLenum matrixMode);

error::Error DoGenPathsCHROMIUM(GLuint path, GLsizei range);

error::Error DoDeletePathsCHROMIUM(GLuint path, GLsizei range);

@@ -893,4 +925,4 @@ error::Error DoGetFragDataIndexEXT(GLuint program,

error::Error DoUniformMatrix4fvStreamTextureMatrixCHROMIUM(

GLint location,

GLboolean transpose,

- const GLfloat* defaultValue);

+ const volatile GLfloat* defaultValue);