milo/appengine/buildbot/build.go - Issue 2275123002: Milo: pRPC endpoint for getting Buildbot master data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/build.go

Issue 2275123002: Milo: pRPC endpoint for getting Buildbot master data (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Update config tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: milo/appengine/buildbot/build.go

diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go

index 46e5dfbfe0b3890d0f1462b4469502f9a8506856..9fa2dc1ebc70e3834c16469a9dccbbeef41eb83f 100644

--- a/milo/appengine/buildbot/build.go

+++ b/milo/appengine/buildbot/build.go

@@ -122,7 +122,7 @@ func getBanner(c context.Context, b *buildbotBuild, m *buildbotMaster) *resp.Log

logos := &resp.LogoBanner{}

// Fetch the master info from datastore if not provided.

if m == nil {

- m1, _, _, err := getMasterJSON(c, b.Master)

+ m1, _, err := getMasterJSON(c, b.Master)

m = m1

if err != nil {

logging.Warningf(c, "Failed to fetch master information for banners on master %s", b.Master)

« milo/api/proto/buildbot.proto ('K') | « milo/api/proto/pb.discovery.go ('k') | milo/appengine/buildbot/builder.go » ('j') | milo/appengine/buildbot/master.go » ('J')