Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2275113004: Clarify full and prefix variables. (Closed)

Created:
4 years, 3 months ago by Peter Wen
Modified:
4 years, 3 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify full and prefix variables. BUG=640625 Committed: https://crrev.com/0b8739a23d597e4602e4de5a794908d9820e0bcc Cr-Commit-Position: refs/heads/master@{#414539}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove space. #

Patch Set 3 : Rebase. #

Messages

Total messages: 16 (9 generated)
Peter Wen
4 years, 3 months ago (2016-08-25 13:39:29 UTC) #4
Theresa
lgtm - this should probably land after Ted's change to move some tabbed mode specific ...
4 years, 3 months ago (2016-08-25 15:13:57 UTC) #7
Peter Wen
Thanks Theresa. Will land after Ted's changes. +dfalcantara@ for OWNERS. https://codereview.chromium.org/2275113004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java (right): https://codereview.chromium.org/2275113004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java#newcode1633 ...
4 years, 3 months ago (2016-08-25 15:49:54 UTC) #9
gone
Lgtm, thanks!
4 years, 3 months ago (2016-08-25 16:10:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275113004/40001
4 years, 3 months ago (2016-08-25 19:59:11 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-25 21:14:26 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 21:16:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b8739a23d597e4602e4de5a794908d9820e0bcc
Cr-Commit-Position: refs/heads/master@{#414539}

Powered by Google App Engine
This is Rietveld 408576698