Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: services/ui/surfaces/surfaces_context_provider.cc

Issue 2275113002: Provide task runner to GLES2Impl / CommandBuffer at creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-cleanup4
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/surfaces/surfaces_context_provider.cc
diff --git a/services/ui/surfaces/surfaces_context_provider.cc b/services/ui/surfaces/surfaces_context_provider.cc
index f1ecf0dc2a06acd76e1958fa5dbed0f30515ef77..11479339ae0bf00254b6574f603c1b66155473dc 100644
--- a/services/ui/surfaces/surfaces_context_provider.cc
+++ b/services/ui/surfaces/surfaces_context_provider.cc
@@ -25,7 +25,9 @@
namespace ui {
SurfacesContextProvider::SurfacesContextProvider(gfx::AcceleratedWidget widget)
- : delegate_(nullptr), widget_(widget) {
+ : delegate_(nullptr),
+ widget_(widget),
+ task_runner_(base::ThreadTaskRunnerHandle::Get()) {
GpuServiceMus* service = GpuServiceMus::GetInstance();
gpu::CommandBufferProxyImpl* shared_command_buffer = nullptr;
gpu::GpuStreamId stream_id = gpu::GpuStreamId::GPU_STREAM_DEFAULT;
@@ -39,11 +41,9 @@ SurfacesContextProvider::SurfacesContextProvider(gfx::AcceleratedWidget widget)
attributes.bind_generates_resource = false;
attributes.lose_context_when_out_of_memory = true;
GURL active_url;
- scoped_refptr<base::SingleThreadTaskRunner> task_runner =
- base::ThreadTaskRunnerHandle::Get();
command_buffer_proxy_impl_ = gpu::CommandBufferProxyImpl::Create(
service->gpu_channel_local(), widget, shared_command_buffer, stream_id,
- stream_priority, attributes, active_url, task_runner);
+ stream_priority, attributes, active_url, task_runner_);
command_buffer_proxy_impl_->SetSwapBuffersCompletionCallback(
base::Bind(&SurfacesContextProvider::OnGpuSwapBuffersCompleted,
base::Unretained(this)));
@@ -88,7 +88,7 @@ bool SurfacesContextProvider::BindToCurrentThread() {
implementation_.reset(new gpu::gles2::GLES2Implementation(
gles2_helper_.get(), NULL, transfer_buffer_.get(),
bind_generates_resource, lose_context_when_out_of_memory,
- support_client_side_arrays, gpu_control));
+ support_client_side_arrays, gpu_control, task_runner_));
return implementation_->Initialize(
default_limits.start_transfer_buffer_size,
default_limits.min_transfer_buffer_size,

Powered by Google App Engine
This is Rietveld 408576698