Convert USERSELECT_ALL to a runtime enabled feature.

Source/core/dom/Node.cpp

Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index e6df0b1534454c2e2a8cf208f040c85a316b5104..3b1e99d45e34b522c1999a60e7036c3d531c8edb 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -652,14 +652,10 @@ bool Node::rendererIsEditable(EditableLevel editableLevel, UserSelectAllTreatmen
 
     for (const Node* node = this; node; node = node->parentNode()) {
         if ((node->isHTMLElement() || node->isDocumentNode()) && node->renderer()) {
-#if ENABLE(USERSELECT_ALL)
             // Elements with user-select: all style are considered atomic
             // therefore non editable.
-            if (node->renderer()->style()->userSelect() == SELECT_ALL && treatment == UserSelectAllIsAlwaysNonEditable)
+            if (RuntimeEnabledFeatures::userSelectAllEnabled() && node->renderer()->style()->userSelect() == SELECT_ALL && treatment == UserSelectAllIsAlwaysNonEditable)

[adamk, 2013/08/09 21:42:32]

Rather than sprinkling these RuntimeEnabledFeatures checks around, is there some
way to keep style()->userSelect() from ever returning SELECT_ALL if the flag is
off? That seems like a more maintainable approach to runtime flags like this.

[ojan, 2013/08/09 22:10:10]

This code doesn't add a new css value, it changes the behavior of the existing
one. That said, I was able to get rid of a bunch of the sprinkled checks by
using Position::nodeIsUserSelectAll in more places.

                 return false;
-#else
-            UNUSED_PARAM(treatment);
-#endif
             switch (node->renderer()->style()->userModify()) {
             case READ_ONLY:
                 return false;